From: "Bruno Prémont" <bonbons@linux-vserver.org>
To: Richard Purdie <rpurdie@linux.intel.com>,
Len Brown <len.brown@intel.com>,
Harald Welte <laforge@gnumonks.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] backlight, panasonic-laptop: fix incomplete registration failure handling
Date: Fri, 26 Feb 2010 13:20:10 +0100 [thread overview]
Message-ID: <20100226132010.3ffeca88@neptune.home> (raw)
In-Reply-To: <20100221002831.689bace8@neptune.home>
Properly return backlight registration error to parent.
Mark struct backlight_ops as const.
Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org>
Acked-by: Harald Welte <laforge@gnumonks.org> (registration failure)
---
drivers/platform/x86/panasonic-laptop.c | 4 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/panasonic-laptop.c b/drivers/platform/x86/panasonic-laptop.c
index 9012d8d..9b17343 100644
--- a/drivers/platform/x86/panasonic-laptop.c
+++ b/drivers/platform/x86/panasonic-laptop.c
@@ -352,7 +352,7 @@ static int bl_set_status(struct backlight_device *bd)
return acpi_pcc_write_sset(pcc, SINF_DC_CUR_BRIGHT, bright);
}
-static struct backlight_ops pcc_backlight_ops = {
+static const struct backlight_ops pcc_backlight_ops = {
.get_brightness = bl_get,
.update_status = bl_set_status,
};
@@ -644,8 +644,10 @@ static int acpi_pcc_hotkey_add(struct acpi_device *device)
/* initialize backlight */
pcc->backlight = backlight_device_register("panasonic", NULL, pcc,
&pcc_backlight_ops);
- if (IS_ERR(pcc->backlight))
+ if (IS_ERR(pcc->backlight)) {
+ result = PTR_ERR(pcc->backlight);
goto out_input;
+ }
if (!acpi_pcc_retrieve_biosdata(pcc, pcc->sinf)) {
ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
--
1.6.4.4
prev parent reply other threads:[~2010-02-26 12:21 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-20 23:10 [Patch 0/3] backlight Bruno Prémont
2010-02-20 23:10 ` Bruno Prémont
2010-02-20 23:18 ` [PATCH 2/3] backlight: mark struct backlight_ops const Bruno Prémont
2010-02-20 23:18 ` Bruno Prémont
2010-02-20 23:18 ` Bruno Prémont
2010-02-20 23:18 ` Bruno Prémont
[not found] ` <20100221001851.673db863-hY15tx4IgV39zxVx7UNMDg@public.gmane.org>
2010-02-22 19:35 ` Mike Frysinger
2010-02-22 19:35 ` Mike Frysinger
2010-02-22 19:35 ` Mike Frysinger
2010-02-22 19:35 ` Mike Frysinger
2010-02-26 11:56 ` [PATCH] " Bruno Prémont
2010-02-26 11:56 ` Bruno Prémont
2010-02-20 23:20 ` [PATCH 1/3] backlight: Add backlight_device parameter to check_fb Bruno Prémont
2010-02-20 23:20 ` Bruno Prémont
[not found] ` <20100221002001.0a7e05a7-hY15tx4IgV39zxVx7UNMDg@public.gmane.org>
2010-02-24 16:00 ` [PATCH 1/3] picolcd: driver for PicoLCD HID device Bruno Prémont
2010-02-24 16:00 ` Bruno Prémont
2010-02-24 16:00 ` Bruno Prémont
[not found] ` <20100224163101.3622d69f@neptune.home>
2010-02-24 16:01 ` [PATCH 2/3] hid: add suspend/resume hooks for hid drivers Bruno Prémont
2010-02-25 4:19 ` Oliver Neukum
2010-02-25 10:12 ` Bruno Prémont
[not found] ` <20100224170049.0d04af3c-hY15tx4IgV39zxVx7UNMDg@public.gmane.org>
[not found] ` <20100224163101.3622d69f-hY15tx4IgV39zxVx7UNMDg@public.gmane.org>
2010-02-24 16:01 ` [PATCH 3/3] hid-picolcd: make use of new suspend/resume hooks Bruno Prémont
2010-02-24 16:01 ` Bruno Prémont
2010-02-25 11:07 ` [PATCH 1/3] picolcd: driver for PicoLCD HID device Jiri Kosina
2010-02-25 11:07 ` Jiri Kosina
2010-02-25 11:07 ` Jiri Kosina
[not found] ` <alpine.LNX.2.00.1002251201430.30967-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>
2010-02-25 11:32 ` Bruno Prémont
2010-02-25 11:32 ` Bruno Prémont
2010-02-25 11:32 ` Bruno Prémont
2010-02-25 15:18 ` Jiri Kosina
2010-02-25 15:18 ` Jiri Kosina
2010-02-25 15:18 ` Jiri Kosina
2010-02-25 15:29 ` Bruno Prémont
2010-02-25 15:29 ` Bruno Prémont
[not found] ` <alpine.LNX.2.00.1002251615570.30967-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>
2010-03-13 19:39 ` Bruno Prémont
2010-03-13 19:39 ` Bruno Prémont
2010-03-13 21:35 ` Alan Stern
2010-03-13 21:35 ` Alan Stern
2010-03-13 22:13 ` [PATCH] hid: Register debugfs entries before adding device Bruno Prémont
2010-03-13 22:13 ` Bruno Prémont
2010-03-15 13:48 ` Jiri Kosina
[not found] ` <20100225123214.0523a310-hY15tx4IgV39zxVx7UNMDg@public.gmane.org>
2010-02-25 17:52 ` [PATCH 1/3] picolcd: driver for PicoLCD HID device Rick L. Vinyard, Jr.
2010-02-25 17:52 ` Rick L. Vinyard, Jr.
2010-02-25 17:52 ` Rick L. Vinyard, Jr.
2010-02-26 8:15 ` Dmitry Torokhov
2010-02-26 8:15 ` Dmitry Torokhov
2010-02-26 8:15 ` Dmitry Torokhov
2010-02-24 18:27 ` Oliver Neukum
2010-02-24 18:27 ` Oliver Neukum
2010-02-24 18:27 ` Oliver Neukum
[not found] ` <201002241927.53532.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2010-02-24 21:44 ` Rick L. Vinyard, Jr.
2010-02-24 21:44 ` Rick L. Vinyard, Jr.
2010-02-24 21:44 ` Rick L. Vinyard, Jr.
2010-02-25 4:11 ` Oliver Neukum
2010-02-25 4:11 ` Oliver Neukum
2010-02-25 11:00 ` Jiri Kosina
2010-02-25 11:00 ` Jiri Kosina
2010-02-25 15:34 ` Rick L. Vinyard, Jr.
2010-02-25 15:34 ` Rick L. Vinyard, Jr.
2010-02-26 8:12 ` Dmitry Torokhov
2010-02-26 8:12 ` Dmitry Torokhov
2010-03-03 6:04 ` Pavel Machek
2010-03-03 6:04 ` Pavel Machek
2010-02-26 11:53 ` [PATCH] backlight: Add backlight_device parameter to check_fb Bruno Prémont
2010-02-26 11:53 ` Bruno Prémont
2010-02-20 23:28 ` [PATCH 3/3] backlight: fix missing/incomplete registration failure Bruno Prémont
2010-02-20 23:28 ` [PATCH 3/3] backlight: fix missing/incomplete registration failure handling Bruno Prémont
2010-02-21 8:04 ` Harald Welte
2010-02-21 13:35 ` [PATCH 3/3] backlight: fix missing/incomplete registration Thadeu Lima de Souza Cascardo
2010-02-21 13:35 ` [PATCH 3/3] backlight: fix missing/incomplete registration failure handling Thadeu Lima de Souza Cascardo
2010-02-24 15:33 ` [PATCH 3/3] backlight: fix missing/incomplete registration Anisse Astier
2010-02-24 15:33 ` [PATCH 3/3] backlight: fix missing/incomplete registration failure handling Anisse Astier
2010-02-26 11:59 ` [PATCH] backlight, classmate-laptop: fix missing " Bruno Prémont
2010-02-26 16:20 ` Thadeu Lima de Souza Cascardo
2010-02-26 16:32 ` Matthew Garrett
2010-02-26 16:45 ` Richard Purdie
2010-02-26 22:25 ` Bruno Prémont
2010-02-26 12:02 ` [PATCH] backlight, appledisplay: fix incomplete " Bruno Prémont
2010-02-26 12:04 ` [PATCH] backlight, blackfin: fix missing registration failure Bruno Prémont
2010-02-26 12:04 ` [PATCH] backlight, blackfin: fix missing registration failure handling Bruno Prémont
2010-02-26 12:17 ` [PATCH] backlight, msi-laptop, msi-wmi: fix incomplete " Bruno Prémont
2010-02-26 12:20 ` Bruno Prémont [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100226132010.3ffeca88@neptune.home \
--to=bonbons@linux-vserver.org \
--cc=laforge@gnumonks.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.