From: "John W. Linville" <linville@tuxdriver.com>
To: Dan Williams <dcbw@redhat.com>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH resend] airo: return from set_wep_key() when key length is zero
Date: Fri, 26 Feb 2010 20:26:17 -0500 [thread overview]
Message-ID: <20100227012616.GA2590@tuxdriver.com> (raw)
In-Reply-To: <1267225769.14995.10.camel@localhost.localdomain>
On Fri, Feb 26, 2010 at 03:09:29PM -0800, Dan Williams wrote:
> On Fri, 2010-02-26 at 15:10 +0100, Stanislaw Gruszka wrote:
> > Even if keylen == 0 is a bug and should not really happen, better avoid
> > possibility of passing bad value to firmware.
> >
> > Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
>
> I actually told John to just apply your first patch via IRC, but perhaps
> he hasn't done that yet. I cannot reproduce the issue that Chris
> encountered with my PCMCIA 350 using 5.60 firmware, and I bricked my
> card loading 5.40 firmware (same as Chris) onto it.
>
> I couldn't find any failures your original patch on my 5.60 device, my
> objections were simply code flow and semantics. So I'll ack the
> original patch.
commit f09c256375c7cf1e112b8ef6306cdd313490d7c0
Author: Stanislaw Gruszka <sgruszka@redhat.com>
Date: Tue Feb 2 15:34:50 2010 +0100
airo: fix setting zero length WEP key
Patch prevents call set_wep_key() with zero key length. That fix long
standing regression since commit c0380693520b1a1e4f756799a0edc379378b462a
"airo: clean up WEP key operations". Additionally print call trace when
someone will try to use improper parameters, and remove key.len = 0
assignment, because it is in not possible code path.
Reported-by: Chris Siebenmann <cks-rhbugzilla@cs.toronto.edu>
Bisected-by: Chris Siebenmann <cks-rhbugzilla@cs.toronto.edu>
Tested-by: Chris Siebenmann <cks@cs.toronto.edu>
Cc: Dan Williams <dcbw@redhat.com>
Cc: <stable@kernel.org>
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Hth...
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-02-27 1:27 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 14:34 [PATCH] airo: fix setting zero length WEP key Stanislaw Gruszka
2010-02-02 18:32 ` Chris Siebenmann
2010-02-03 20:43 ` Dan Williams
2010-02-03 21:31 ` Chris Siebenmann
2010-02-04 21:44 ` Dan Williams
2010-02-04 22:10 ` Chris Siebenmann
2010-02-04 22:18 ` Dan Williams
2010-02-04 22:26 ` Chris Siebenmann
2010-02-04 22:39 ` Dan Williams
2010-02-04 22:42 ` Chris Siebenmann
2010-02-04 23:00 ` Dan Williams
2010-02-04 23:03 ` Chris Siebenmann
2010-02-04 23:26 ` Dan Williams
2010-02-04 23:30 ` Dan Williams
2010-02-04 23:36 ` Chris Siebenmann
2010-02-05 6:57 ` Dan Williams
2010-02-04 12:04 ` Stanislaw Gruszka
2010-02-04 12:07 ` [PATCH v2] " Stanislaw Gruszka
2010-02-04 16:41 ` Chris Siebenmann
2010-02-04 23:56 ` Dan Williams
2010-02-05 9:11 ` Stanislaw Gruszka
2010-02-05 6:59 ` Dan Williams
2010-02-05 7:06 ` [PATCH] airo: fix WEP key clearing after c0380693520b1a1e4f756799a0edc379378b462a Dan Williams
2010-02-05 16:26 ` Chris Siebenmann
2010-02-05 19:20 ` Dan Williams
2010-02-05 23:12 ` Chris Siebenmann
2010-02-08 23:47 ` Dan Williams
2010-02-09 16:25 ` Chris Siebenmann
2010-02-09 17:17 ` Chris Siebenmann
2010-02-08 20:55 ` [PATCH v2] airo: fix setting zero length WEP key John W. Linville
2010-02-08 23:44 ` Dan Williams
2010-02-08 20:53 ` John W. Linville
2010-02-09 8:27 ` [PATCH] airo: return from set_wep_key() when key length is zero Stanislaw Gruszka
2010-02-26 14:10 ` [PATCH resend] " Stanislaw Gruszka
2010-02-26 23:09 ` Dan Williams
2010-02-27 1:26 ` John W. Linville [this message]
2010-03-01 7:47 ` Stanislaw Gruszka
2010-02-26 23:09 ` [PATCH v2] airo: fix setting zero length WEP key Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100227012616.GA2590@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=dcbw@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.