Re: [PATCH] Set session state to RESPONSE_SENT after sending response.

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]

Hi Andrew,

Good catch, patch has been applied.

> Hi Denis,
> I am not entirely sure this new state is needed though.  As the commit says
> the network may continue the dialog but it is not obliged to send any kind

The state is actually meant to un-confuse the USSD_STATE_ACTIVE if clause in 
ofono_ussd_notify.  Otherwise we treat it exactly like USSD_STATE_ACTIVE.

> of response to our reponse, at least this is not in the specs.  So if it
> doesn't send anything (neither a notification nor request) we will remain
> in this state and user will not be able to Initiate a new session for that

In theory the modem should time out the USSD request and send us a notification 
regardless.  I'm afraid we have to rely on the modem for this one, since the 
modem would refuse to send USSDs if a session is active anyway.

> time.  The other option, if I misunderstood the spec, would be to make the
> Respond method return the string.

I'm actually open to the idea, the reason 'Initiate' returns a string is that 
95% of the time there is no dialog, just straight request -> response.

Regards,
-Denis