From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: only modify hna-table on active module
Date: Sat, 27 Feb 2010 13:44:36 +0800 [thread overview]
Message-ID: <201002271344.36630.lindner_marek@yahoo.de> (raw)
In-Reply-To: <20100227021157.GA4116@Linus-Debian>
Hey,
nice patch and this time well formatted. ;-)
Applied in 1578.
> Just for some more clarification about this bug (have a look at
> the attached call trace): It always occurs when I haven't put an
> interface into batman-adv and when I'm then changing the
> mac-address of bat0. I've now added a little check in
> interface_set_mac_addr() which seems to work nicely here in my
> setup. I'm also wondering if we should add another sanity check
> somewhere in hna_local_add() to directly avoid any racy null
> pointer dereferences in there.
I'm not sure it is a good place to put such a check since hna_local_add() is
more of a library function which does not know much about the context.
However, it could check whether the hna_local_hash had been initialized.
Cheers,
Marek
prev parent reply other threads:[~2010-02-27 5:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-27 1:49 [B.A.T.M.A.N.] [PATCH] batman-adv: only modify hna-table on active module Linus Lüssing
2010-02-27 2:11 ` Linus Lüssing
2010-02-27 5:44 ` Marek Lindner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002271344.36630.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.