From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NlOYB-0002gb-Gk for qemu-devel@nongnu.org; Sat, 27 Feb 2010 10:25:51 -0500 Received: from [199.232.76.173] (port=50650 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NlOYB-0002gN-19 for qemu-devel@nongnu.org; Sat, 27 Feb 2010 10:25:51 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NlOY9-0006Bj-RJ for qemu-devel@nongnu.org; Sat, 27 Feb 2010 10:25:50 -0500 Received: from hall.aurel32.net ([88.191.82.174]:54197) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NlOY9-0006BU-88 for qemu-devel@nongnu.org; Sat, 27 Feb 2010 10:25:49 -0500 Date: Sat, 27 Feb 2010 16:25:44 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] arm host: Fix linker warning (m68k targets) Message-ID: <20100227152544.GC10291@volta.aurel32.net> References: <4B844517.6030607@linux.vnet.ibm.com> <1266960743-11496-1-git-send-email-weil@mail.berlios.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1266960743-11496-1-git-send-email-weil@mail.berlios.de> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-devel@nongnu.org On Tue, Feb 23, 2010 at 10:32:23PM +0100, Stefan Weil wrote: > Compilation of m68k-softmmu or m68k-linux-user on arm host > (or cross compilation for arm) results in a linker warning: > > LINK m68k-softmmu/qemu-system-m68k > m68k-dis.o: warning: definition of `floatformat_ieee_single_little' overriding common > arm-dis.o: warning: common is here > /usr/lib/gcc/arm-linux-gnueabi/4.3.2/../../../../arm-linux-gnueabi/bin/ld: Warning: size of symbol `floatformat_ieee_single_little' changed from 4 in arm-dis.o to 48 in m68k-dis.o > > floatformat_ieee_single_little is declared in arm-dis.c and m68k-dis.c, > and both declarations don't match, so this is an error. > > The symbol is not needed in arm-dis.c, so I removed it there. Thanks, applied. > Signed-off-by: Stefan Weil > --- > arm-dis.c | 8 ++------ > 1 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/arm-dis.c b/arm-dis.c > index 2c67d8f..4fb899e 100644 > --- a/arm-dis.c > +++ b/arm-dis.c > @@ -60,10 +60,8 @@ > #define FPU_VFP_EXT_V3 0 > #define FPU_NEON_EXT_V1 0 > > -int floatformat_ieee_single_little; > /* Assume host uses ieee float. */ > -static void floatformat_to_double (int *ignored, unsigned char *data, > - double *dest) > +static void floatformat_to_double (unsigned char *data, double *dest) > { > union { > uint32_t i; > @@ -2543,9 +2541,7 @@ print_insn_neon (struct disassemble_info *info, long given, bfd_boolean thumb) > valbytes[2] = (value >> 16) & 0xff; > valbytes[3] = (value >> 24) & 0xff; > > - floatformat_to_double > - (&floatformat_ieee_single_little, valbytes, > - &fvalue); > + floatformat_to_double (valbytes, &fvalue); > > func (stream, "#%.7g\t; 0x%.8lx", fvalue, > value); > -- > 1.6.6.1 > > > > -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net