From: Matthias Kaehlcke <matthias@kaehlcke.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ep93xx timer: Fix get_ticks() and usecs_to_ticks()
Date: Sun, 28 Feb 2010 00:58:02 +0100 [thread overview]
Message-ID: <20100227235802.GD1667@darwin> (raw)
In-Reply-To: <4B89ADA6.8020304@windriver.com>
Hi Tom,
El Sat, Feb 27, 2010 at 05:41:26PM -0600 Tom ha dit:
> Matthias Kaehlcke wrote:
> >ep93xx timer: Make get_ticks() consistent with get_tbclk(), returning
> >a value with CONFIG_SYS_HZ resolution. This fix obsoletes the function
> >clk_to_systicks(), leading to a simplification of the timer code. Further
> >a variable in usecs_to_ticks() is promoted to a 64-bit value, to avoid
> >overflows of intermediate values.
> >
> >Signed-off-by: Matthias Kaehlcke <matthias@kaehlcke.net>
> >Tested-by: Alessandro Rubini <rubini-list@gnudd.com>
> >
> Please rebase.
> I applied the earlier version.
it is based on the earlier version
> I think these changes should be a much smaller patch.
the patch without rebasing would have been shorter than the earlier
one(s), that's why i proposed reverting the other one(s).
making get_ticks() work with CONFIG_SYS_HZ resolution implied moving
code around functions and removing code from others, resulting in a
larger patch (but in resume in more compact and more readable code).
best regards
--
Matthias Kaehlcke
Embedded Linux Developer
Barcelona
Comunicar bichos a <bug-coreutils@gnu.org>
(LANG=es_ES uname --help)
.''`.
using free software / Debian GNU/Linux | http://debian.org : :' :
`. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `-
prev parent reply other threads:[~2010-02-27 23:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-26 17:26 [U-Boot] [PATCH] ep93xx timer: Fix get_ticks() and usecs_to_ticks() Matthias Kaehlcke
2010-02-27 23:41 ` Tom
2010-02-27 23:58 ` Matthias Kaehlcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100227235802.GD1667@darwin \
--to=matthias@kaehlcke.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.