From: Luca Berra <bluca@comedia.it>
To: "linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>
Cc: "Neil Brown (neilb@suse.de)" <neilb@suse.de>
Subject: [mdadm PATCH 4/9] mdmon: check select a writable pid_dir
Date: Sun, 28 Feb 2010 15:42:57 +0100 [thread overview]
Message-ID: <20100228144257.GC24781@maude.comedia.it> (raw)
In-Reply-To: <cover.1267282753.git.bluca@comedia.it>
Check that either VAR_DIR or ALT_DIR is actually writable before
selecting it.
Signed-off-by: Luca Berra <bluca@comedia.it>
---
mdmon.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/mdmon.c b/mdmon.c
index 11b4f32..57fd492 100644
--- a/mdmon.c
+++ b/mdmon.c
@@ -480,9 +480,9 @@ static int mdmon(char *devname, int devnum, int must_fork, int takeover)
*/
if (victim > 0)
remove_pidfile(devname);
- if (mkdir(VAR_RUN, 0600) >= 0 || errno == EEXIST)
+ if (mkdir(VAR_RUN, 0600) >= 0 || (errno == EEXIST && access(VAR_RUN, W_OK) >= 0))
pid_dir = VAR_RUN;
- else if (mkdir(ALT_RUN, 0600) >= 0 || errno == EEXIST)
+ else if (mkdir(ALT_RUN, 0600) >= 0 || (errno == EEXIST && access(ALT_RUN, W_OK) >= 0))
pid_dir = ALT_RUN;
else {
fprintf(stderr, "mdmon: Neither %s nor %s are writable\n"
--
1.7.0
--
Luca Berra -- bluca@comedia.it
Communication Media & Services S.r.l.
/"\
\ / ASCII RIBBON CAMPAIGN
X AGAINST HTML MAIL
/ \
next prev parent reply other threads:[~2010-02-28 14:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-27 15:05 [mdadm PATCH 0/2] *** mdmon fixes *** Luca Berra
2010-02-27 15:07 ` [mdadm PATCH 1/2] fix mdmon option parsing Luca Berra
2010-02-27 15:21 ` Luca Berra
2010-03-02 5:40 ` Neil Brown
2010-03-02 7:42 ` Luca Berra
2010-02-27 15:07 ` [mdadm PATCH 2/2] fix mdmon takeover Luca Berra
2010-03-03 0:52 ` Neil Brown
2010-02-28 14:41 ` [mdadm PATCH 0/2] *** mdmon fixes *** Luca Berra
2010-02-28 15:41 ` Bill Davidsen
2010-02-28 17:37 ` Luca Berra
2010-02-28 14:42 ` [mdadm PATCH 3/9] add missing newline to mdmon usage message Luca Berra
2010-02-28 14:42 ` Luca Berra [this message]
2010-03-03 1:07 ` [mdadm PATCH 4/9] mdmon: check select a writable pid_dir Neil Brown
2010-02-28 14:43 ` [mdadm PATCH 5/9] mdmon: mdmon_pid should return pid from either dir Luca Berra
2010-03-03 1:50 ` Neil Brown
2010-03-03 6:44 ` Luca Berra
2010-03-03 6:55 ` Neil Brown
2010-03-03 7:09 ` Luca Berra
2010-02-28 14:44 ` [mdadm PATCH 6/9] mdmon: connect_monitor should use socket " Luca Berra
2010-03-03 1:51 ` Neil Brown
2010-02-28 14:45 ` [mdadm PATCH 7/9] mdmon: move pid_dir to mdmon.c Luca Berra
2010-02-28 14:45 ` [mdadm PATCH 8/9] mdmon: rework startup and takeover logic Luca Berra
2010-03-03 1:52 ` Neil Brown
2010-03-03 6:48 ` Luca Berra
2010-02-28 14:46 ` [mdadm PATCH 9/9] allow redefinition of VAR_RUN Luca Berra
2010-03-03 1:53 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100228144257.GC24781@maude.comedia.it \
--to=bluca@comedia.it \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.