From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Alessandro Zummo <a.zummo@towertech.it>
Cc: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
Paul Gortmaker <p_gortmaker@yahoo.com>,
Andrew Morton <akpm@linux-foundation.org>,
Valentin Longchamp <valentin.longchamp@epfl.ch>,
Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: [rtc-linux] [PATCH 6/6] rtc/mc13783: implement alarm
Date: Mon, 1 Mar 2010 12:10:07 +0100 [thread overview]
Message-ID: <20100301111007.GD16049@pengutronix.de> (raw)
In-Reply-To: <20100301115625.5d048580@linux.lan.towertech.it>
On Mon, Mar 01, 2010 at 11:56:25AM +0100, Alessandro Zummo wrote:
> On Mon, 1 Mar 2010 11:53:45 +0100
> Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
>
> > for now this just ignores the possible race to trigger an alarm when
> > setting the time. Should I resolve that, if so, what is the prefered
> > way to do that?
>
> I saw you email on the topic but I haven't had
> the time to answer appropriately.
>
> I'd suggest to disable the alarm irq while setting
> the time.
I have two possibilities, I'm not sure if you mean the first or just any
of the two:
1)
pending = is_alarm_pending
mask_alarm_irq
set time and date
if (!pending)
ack_alarm_irq
unmask_alarm_irq
2)
alarmtime = read_alaram
program_alarm(invalid)
set time and date
program_alarm(alarmtime)
I'd prefer 2), is that OK for you, too?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-03-01 11:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-01 10:53 [PATCH 1/6] mc13783: rename mc13783_{{un,}mask,ack_irq} to have a mc13783_irq prefix Uwe Kleine-König
2010-03-01 10:53 ` [PATCH 2/6] input/mc13783-ts: Don't use deprecated mc13783 API calls Uwe Kleine-König
2010-03-02 7:55 ` Dmitry Torokhov
2010-03-02 7:55 ` Dmitry Torokhov
2010-03-02 8:54 ` Uwe Kleine-König
2010-03-01 10:53 ` [PATCH 3/6] rtc/mc13783: " Uwe Kleine-König
2010-03-01 10:53 ` [PATCH 4/6] mfd/mc13783: new function reading irq mask and status register Uwe Kleine-König
2010-03-01 10:53 ` [PATCH 5/6] rtc/mc13783: protect rtc {,un}registration by mc13783 lock Uwe Kleine-König
2010-03-01 10:53 ` [PATCH 6/6] rtc/mc13783: implement alarm Uwe Kleine-König
2010-03-01 10:56 ` [rtc-linux] " Alessandro Zummo
2010-03-01 11:10 ` Uwe Kleine-König [this message]
2010-03-01 11:45 ` Alessandro Zummo
2010-03-02 9:47 ` [PATCH v2 " Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100301111007.GD16049@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p_gortmaker@yahoo.com \
--cc=rtc-linux@googlegroups.com \
--cc=s.hauer@pengutronix.de \
--cc=valentin.longchamp@epfl.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.