From: Jan Kara <jack@suse.cz>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: Jan Kara <jack@suse.cz>, Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 4/8] dquot: cleanup dquot transfer routine
Date: Mon, 1 Mar 2010 14:45:44 +0100 [thread overview]
Message-ID: <20100301134544.GH3271@quack.suse.cz> (raw)
In-Reply-To: <87d3zo8f0s.fsf@openvz.org>
On Mon 01-03-10 14:20:19, Dmitry Monakhov wrote:
> Jan Kara <jack@suse.cz> writes:
>
> > On Mon 01-03-10 04:50:52, Christoph Hellwig wrote:
> >> On Thu, Feb 25, 2010 at 12:14:14AM +0100, Jan Kara wrote:
> >> > On Sat 20-02-10 06:51:05, Christoph Hellwig wrote:
> >> > > Get rid of the transfer dquot operation - it is now always called from
> >> > > the filesystem and if a filesystem really needs it's own (which none
> >> > > currently does) it can just call into it's own routine directly.
> >> > >
> >> > > Rename the now static low-level dquot_transfer helper to __dquot_transfer
> >> > > and vfs_dq_transfer to dquot_transfer to have a consistent namespace,
> >> > > and make the new dquot_transfer return a normal negative errno value
> >> > > which all callers expect.
> >> > Looks good. I just wonder - if you made dquot_transfer() return error
> >> > code, shouldn't also dquot_alloc_inode, dquot_alloc_space and similar
> >> > return error code instead of 1? It would seem more consistent.
> >>
> >> Probably - I can do that in another pass if you haven't done it yet.
> > I've already done it. See commits
> > 3a3d2903d3e9aaba9ca154606cf2f2613839b079 and
> > bff3333e868578990f6fe794a7cba0c74bd433ac in my linux-fs-2.6 tree.
> I can't find it, in what branch this commits belong?
> May be i've pulled it in wrong way, but i cant find it in
> web fron-end too. Can you please provide a web link
Hmm, probably I was too tired on Wednesday and didn't push after
committing changes. Sorry for that. Now they are pushed. The web interface
should mirror them soon...
They are in 'for_next' branch, subject lines:
dquot: cleanup inode allocation / freeing routines
dquot: cleanup space allocation / freeing routines
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2010-03-01 13:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-20 11:51 [PATCH 0/8] dquot interface cleanups Christoph Hellwig
2010-02-20 11:51 ` [PATCH 1/8] dquot: cleanup space allocation / freeing routines Christoph Hellwig
2010-02-24 22:09 ` Jan Kara
2010-02-20 11:51 ` [PATCH 2/8] dquot: cleanup inode " Christoph Hellwig
2010-02-24 22:39 ` Jan Kara
2010-02-20 11:51 ` [PATCH 3/8] dquot: move dquot transfer responsibiliy into the filesystem Christoph Hellwig
2010-02-24 23:06 ` Jan Kara
2010-02-20 11:51 ` [PATCH 4/8] dquot: cleanup dquot transfer routine Christoph Hellwig
2010-02-24 23:14 ` Jan Kara
2010-03-01 9:50 ` Christoph Hellwig
2010-03-01 10:40 ` Jan Kara
2010-03-01 11:20 ` Dmitry Monakhov
2010-03-01 13:45 ` Jan Kara [this message]
2010-03-01 14:18 ` commiting unreviewed patches, was " Christoph Hellwig
2010-03-02 17:43 ` Jan Kara
2010-02-20 11:51 ` [PATCH 5/8] dquot: move dquot drop responsibiliy into the filesystem Christoph Hellwig
2010-02-25 0:00 ` Jan Kara
2010-02-20 11:51 ` [PATCH 6/8] dquot: cleanup dquot drop routine Christoph Hellwig
2010-02-25 0:08 ` Jan Kara
2010-02-20 11:51 ` [PATCH 7/8] dquot: move dquot initialization responsibiliy into the filesystem Christoph Hellwig
2010-02-25 0:29 ` Jan Kara
2010-03-02 18:44 ` Jan Kara
2010-03-02 19:50 ` Christoph Hellwig
2010-03-03 8:16 ` Jan Kara
2010-03-03 13:02 ` Christoph Hellwig
2010-02-20 11:51 ` [PATCH 8/8] dquot: cleanup dquot initialize routine Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100301134544.GH3271@quack.suse.cz \
--to=jack@suse.cz \
--cc=dmonakhov@openvz.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.