From: Ingo Molnar <mingo@elte.hu>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, laijs@cn.fujitsu.com,
dipankar@in.ibm.com, akpm@linux-foundation.org,
mathieu.desnoyers@polymtl.ca, josh@joshtriplett.org,
dvhltc@us.ibm.com, niv@us.ibm.com, tglx@linutronix.de,
peterz@infradead.org, rostedt@goodmis.org,
Valdis.Kletnieks@vt.edu, dhowells@redhat.com
Subject: Re: [PATCH RFC tip/core/rcu 1/2] rcu: suppress RCU lockdep warnings during early boot
Date: Tue, 2 Mar 2010 13:20:59 +0100 [thread overview]
Message-ID: <20100302122059.GA8247@elte.hu> (raw)
In-Reply-To: <1267470234-27150-1-git-send-email-paulmck@linux.vnet.ibm.com>
* Paul E. McKenney <paulmck@linux.vnet.ibm.com> wrote:
> + if (!rcu_scheduler_active || !debug_locks)
> + return 1;
> + return lock_is_held(&rcu_lock_map);
> + if (!rcu_scheduler_active || !debug_locks)
> + return 1;
> + return lock_is_held(&rcu_bh_lock_map);
i guess there could be a common helper here?
Also, could we clear rcu_scheduler_active when we clear debug_locks? That way
only a single test is needed, a generic 'is lock debugging active'.
(Which test should probably be unlikely() as well?)
Ingo
next prev parent reply other threads:[~2010-03-02 12:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-01 19:03 [PATCH RFC tip/core/rcu 0/2] rcu: make RCU lockdep handle early boot in organized manner Paul E. McKenney
2010-03-01 19:03 ` [PATCH RFC tip/core/rcu 1/2] rcu: suppress RCU lockdep warnings during early boot Paul E. McKenney
2010-03-02 12:20 ` Ingo Molnar [this message]
2010-03-02 13:27 ` Paul E. McKenney
2010-03-02 14:12 ` Ingo Molnar
2010-03-02 14:55 ` Paul E. McKenney
2010-03-01 19:03 ` [PATCH RFC tip/core/rcu 2/2] rcu: revert 1883c79a: early boot now handled by lockdep-RCU Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100302122059.GA8247@elte.hu \
--to=mingo@elte.hu \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=dvhltc@us.ibm.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=niv@us.ibm.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.