From: Andrew Morton <akpm@linux-foundation.org>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: linux-kernel@vger.kernel.org, Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH -mm 7/7] pci: move pci_set_dma_mask and pci_set_consistent_dma_mask to pci-dma-compat.h
Date: Tue, 2 Mar 2010 18:29:27 -0800 [thread overview]
Message-ID: <20100302182927.0099eb68.akpm@linux-foundation.org> (raw)
In-Reply-To: <1265967212-9126-8-git-send-email-fujita.tomonori@lab.ntt.co.jp>
On Fri, 12 Feb 2010 18:33:32 +0900 FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> wrote:
> We can use pci-dma-compat.h to implement pci_set_dma_mask and
> pci_set_consistent_dma_mask as we do with the other PCI DMA API.
>
> We can remove HAVE_ARCH_PCI_SET_DMA_MASK too.
i386 allnoconfig:
include/asm-generic/pci-dma-compat.h:105: error: redefinition of 'pci_set_dma_mask'
include/linux/pci.h:1092: error: previous definition of 'pci_set_dma_mask' was here
include/asm-generic/pci-dma-compat.h:110: error: redefinition of 'pci_set_consistent_dma_mask'
include/linux/pci.h:1097: error: previous definition of 'pci_set_consistent_dma_mask' was here
In fact the whole of include/asm-generic/pci-dma-compat.h seems a bit
fishy when CONFIG_PCI=n. Shouldn't all those functions be
EIO-returning stubs?
next prev parent reply other threads:[~2010-03-03 2:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-12 9:33 [PATCH -mm 0/7] transforming the PCI DMA API into the generic device model FUJITA Tomonori
2010-02-12 9:33 ` [PATCH -mm 1/7] sparc: unify 32bit and 64bit dma_set_mask FUJITA Tomonori
2010-02-13 1:09 ` David Miller
2010-02-12 9:33 ` [PATCH -mm 2/7] alpha: use include/linux/pci-dma-compat.h FUJITA Tomonori
2010-02-12 9:33 ` [PATCH -mm 3/7] pci: convert pci_set_dma_mask to call dma_set_mask FUJITA Tomonori
2010-02-14 23:33 ` Benjamin Herrenschmidt
2010-02-12 9:33 ` [PATCH -mm 4/7] dma-mapping.h: add dma_set_coherent_mask FUJITA Tomonori
2010-02-12 9:33 ` [PATCH -mm 5/7] powerpc: use generic pci_set_dma_mask and pci_set_consistent_dma_mask FUJITA Tomonori
2010-02-14 23:36 ` Benjamin Herrenschmidt
2010-02-15 1:57 ` FUJITA Tomonori
2010-02-15 2:41 ` Benjamin Herrenschmidt
2010-02-12 9:33 ` [PATCH -mm 6/7] arm: " FUJITA Tomonori
2010-02-12 15:01 ` Russell King - ARM Linux
2010-02-12 9:33 ` [PATCH -mm 7/7] pci: move pci_set_dma_mask and pci_set_consistent_dma_mask to pci-dma-compat.h FUJITA Tomonori
2010-03-03 2:29 ` Andrew Morton [this message]
2010-03-03 2:58 ` FUJITA Tomonori
2010-03-03 16:23 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100302182927.0099eb68.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.