From: "John W. Linville" <linville@tuxdriver.com>
To: matthieu castet <castet.matthieu@free.fr>
Cc: linux-wireless@vger.kernel.org, Dan Williams <dcbw@redhat.com>,
Jose Alonso <joalonsof@gmail.com>
Subject: Re: [PATCH] airo : Print of firmware version
Date: Wed, 3 Mar 2010 15:14:11 -0500 [thread overview]
Message-ID: <20100303201411.GF23920@tuxdriver.com> (raw)
In-Reply-To: <4B8A80EE.6000102@free.fr>
On Sun, Feb 28, 2010 at 03:42:54PM +0100, matthieu castet wrote:
> For the firmware version 5.30.17 the log file shows:
> Firmware version 5.30.11
>
> The variable softSubVer is binary.
>
>
> Signed-off-by: Matthieu CASTET <castet.matthieu@free.fr>
> Signed-off-by: Jose Alonso <joalonsof@gmail.com>
> Index: airo.c
> ===================================================================
> --- 1/drivers/net/wireless/airo.c (r?vision 47)
> +++ 2/drivers/net/wireless/airo.c (r?vision 48)
> @@ -2993,7 +2993,7 @@
> ai->wep_capable = (cap_rid.softCap & cpu_to_le16(0x02)) ? 1 : 0;
> ai->max_wep_idx = (cap_rid.softCap & cpu_to_le16(0x80)) ? 3 : 0;
>
> - airo_print_info(dev->name, "Firmware version %x.%x.%02x",
> + airo_print_info(dev->name, "Firmware version %x.%x.%02d",
> ((le16_to_cpu(cap_rid.softVer) >> 8) & 0xF),
> (le16_to_cpu(cap_rid.softVer) & 0xFF),
> le16_to_cpu(cap_rid.softSubVer));
Why should the last segment be in decimal form if the other two
segments of the version number are in hexadecimal form?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-03-03 20:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-28 14:42 [PATCH] airo : Print of firmware version matthieu castet
2010-03-03 20:14 ` John W. Linville [this message]
2010-03-03 23:12 ` Jose Alonso
2010-03-04 2:20 ` John W. Linville
2010-03-04 16:06 ` Dan Williams
2010-03-04 16:10 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100303201411.GF23920@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=castet.matthieu@free.fr \
--cc=dcbw@redhat.com \
--cc=joalonsof@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.