From: Ingo Molnar <mingo@elte.hu>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, efault@gmx.de, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [rfc/rft][patch] should use scheduler sync hint in tcp_prequeue()?
Date: Thu, 4 Mar 2010 04:03:00 +0100 [thread overview]
Message-ID: <20100304030300.GE23633@elte.hu> (raw)
In-Reply-To: <20100303.060529.195713861.davem@davemloft.net>
* David Miller <davem@davemloft.net> wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Tue, 02 Mar 2010 12:27:53 +0100
>
> > Le mardi 02 mars 2010 ? 10:41 +0100, Mike Galbraith a ?crit :
> >> diff --git a/include/net/tcp.h b/include/net/tcp.h
> >> index 34f5cc2..ba3fc64 100644
> >> --- a/include/net/tcp.h
> >> +++ b/include/net/tcp.h
> >> @@ -939,7 +939,7 @@ static inline int tcp_prequeue(struct sock *sk, struct sk_buff *skb)
> >>
> >> tp->ucopy.memory = 0;
> >> } else if (skb_queue_len(&tp->ucopy.prequeue) == 1) {
> >> - wake_up_interruptible_poll(sk->sk_sleep,
> >> + wake_up_interruptible_sync_poll(sk->sk_sleep,
> >> POLLIN | POLLRDNORM | POLLRDBAND);
> >> if (!inet_csk_ack_scheduled(sk))
> >> inet_csk_reset_xmit_timer(sk, ICSK_TIME_DACK,
> >>
> ...
> > Ingo probably can answer to this question, since he changed
> > sock_def_readable() (and others) in commit 6f3d09291b498299
> > I suspect he missed tcp_prequeue() case, maybe not...
>
> It definitely looks like an oversight to me and we should add
> be using wake_up_interruptible_sync_poll() in tcp_prequeue()
> as above.
>
> Ingo?
Yeah. I remember that patch, it was minimalistic, based on the workload i
could trigger back then.
Thanks,
Ingo
prev parent reply other threads:[~2010-03-04 3:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-02 9:41 [rfc/rft][patch] should use scheduler sync hint in tcp_prequeue()? Mike Galbraith
2010-03-02 11:27 ` Eric Dumazet
2010-03-02 11:32 ` Peter Zijlstra
2010-03-02 11:41 ` Mike Galbraith
2010-03-02 11:39 ` Mike Galbraith
2010-03-03 14:05 ` David Miller
2010-03-03 14:46 ` Mike Galbraith
2010-03-04 8:41 ` David Miller
2010-03-04 3:03 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100304030300.GE23633@elte.hu \
--to=mingo@elte.hu \
--cc=davem@davemloft.net \
--cc=efault@gmx.de \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.