From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 4 Mar 2010 04:18:47 +0100 From: Ingo Molnar Message-ID: <20100304031847.GA22683@elte.hu> References: <20100302180915.1388d3f3.sfr@canb.auug.org.au> <4B8D4607.8070603@xenotime.net> <20100303.012359.66790294.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100303.012359.66790294.davem@davemloft.net> Subject: Re: [Bridge] [PATCH -next] bridge: depends on INET List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Miller Cc: sfr@canb.auug.org.au, netdev@vger.kernel.org, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, rdunlap@xenotime.net, linux-next@vger.kernel.org * David Miller wrote: > From: Randy Dunlap > Date: Tue, 02 Mar 2010 09:08:23 -0800 > > > From: Randy Dunlap > > > > br_multicast calls ip_send_check(), so it should depend on INET. > > > > built-in: > > br_multicast.c:(.text+0x88cf4): undefined reference to `ip_send_check' > > > > or modular: > > ERROR: "ip_send_check" [net/bridge/bridge.ko] undefined! > > > > Signed-off-by: Randy Dunlap > > Applied, but I almost lost this patch. > > You need to CC: netdev on all networking patches so that it > gets properly tracked in patchwork and therefore does not get > lost. I suspect Randy went by the MAINTAINERS entry - you might want to add netdev as a second 'L:' line: ETHERNET BRIDGE M: Stephen Hemminger L: bridge@lists.linux-foundation.org W: http://www.linux-foundation.org/en/Net:Bridge S: Maintained F: include/linux/netfilter_bridge/ F: net/bridge/ To make it really clear that netdev must be Cc:-ed for those patches. Thanks, Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH -next] bridge: depends on INET Date: Thu, 4 Mar 2010 04:18:47 +0100 Message-ID: <20100304031847.GA22683@elte.hu> References: <20100302180915.1388d3f3.sfr@canb.auug.org.au> <4B8D4607.8070603@xenotime.net> <20100303.012359.66790294.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20100303.012359.66790294.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org To: David Miller Cc: rdunlap@xenotime.net, sfr@canb.auug.org.au, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, shemminger@linux-foundation.org, bridge@lists.linux-foundation.org, netdev@vger.kernel.org List-Id: linux-next.vger.kernel.org * David Miller wrote: > From: Randy Dunlap > Date: Tue, 02 Mar 2010 09:08:23 -0800 > > > From: Randy Dunlap > > > > br_multicast calls ip_send_check(), so it should depend on INET. > > > > built-in: > > br_multicast.c:(.text+0x88cf4): undefined reference to `ip_send_check' > > > > or modular: > > ERROR: "ip_send_check" [net/bridge/bridge.ko] undefined! > > > > Signed-off-by: Randy Dunlap > > Applied, but I almost lost this patch. > > You need to CC: netdev on all networking patches so that it > gets properly tracked in patchwork and therefore does not get > lost. I suspect Randy went by the MAINTAINERS entry - you might want to add netdev as a second 'L:' line: ETHERNET BRIDGE M: Stephen Hemminger L: bridge@lists.linux-foundation.org W: http://www.linux-foundation.org/en/Net:Bridge S: Maintained F: include/linux/netfilter_bridge/ F: net/bridge/ To make it really clear that netdev must be Cc:-ed for those patches. Thanks, Ingo