All of lore.kernel.org
 help / color / mirror / Atom feed
From: Myron Stowe <myron.stowe@hp.com>
To: minyard@acm.org
Cc: linux-acpi@vger.kernel.org,
	openipmi-developer@lists.sourceforge.net, lenb@kernel.org
Subject: [PATCH 1/4] ipmi: Raise precedence of PNP based discovery mechanisms (ACPI, PCI)
Date: Wed, 03 Mar 2010 20:44:10 -0700	[thread overview]
Message-ID: <20100304034410.30205.13074.stgit@bob.kio> (raw)
In-Reply-To: <20100304033146.30205.68689.stgit@bob.kio>

This raises the precedence of PNP discovery mechanisms, ACPI and  PCI,
above SMBIOS and SPMI as indicated by Appendix C1 of the IPMI
specification.

Reference: IPMI - Intelligent Platform Management Interface Specification
           v2.0, Document Revision 1.0, 05.05.2005 Markup

  Appendix C1 - Locating IPMI System Interfaces via SMBIOS Tables
      "Note that the settings that this structure reports may be over-
      ridden by `Plug-and-Play' reassignment by the OS.  Therefore, this
      structure should be used only when the interface cannot be
      discovered via `Plug-and-Play' discovery mechanisms incorporated
      in interfaces such as PCI and ACPI."

Signed-off-by: Myron Stowe <myron.stowe@hp.com>
---

 drivers/char/ipmi/ipmi_si_intf.c |   15 ++++++++-------
 1 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 176f175..86a7dd7 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -3197,13 +3197,6 @@ static __devinit int init_ipmi_si(void)
 
 	hardcode_find_bmc();
 
-#ifdef CONFIG_DMI
-	dmi_find_bmc();
-#endif
-
-#ifdef CONFIG_ACPI
-	spmi_find_bmc();
-#endif
 #ifdef CONFIG_ACPI
 	pnp_register_driver(&ipmi_pnp_driver);
 #endif
@@ -3220,6 +3213,14 @@ static __devinit int init_ipmi_si(void)
 	of_register_platform_driver(&ipmi_of_platform_driver);
 #endif
 
+#ifdef CONFIG_DMI
+	dmi_find_bmc();
+#endif
+
+#ifdef CONFIG_ACPI
+	spmi_find_bmc();
+#endif
+
 	if (si_trydefaults) {
 		mutex_lock(&smi_infos_lock);
 		if (list_empty(&smi_infos)) {


  reply	other threads:[~2010-03-04  3:44 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-04  3:44 [PATCH 0/4] ipmi: remove SPMI and update core driver with dev_printk Myron Stowe
2010-03-04  3:44 ` Myron Stowe [this message]
2010-03-04  3:44 ` [PATCH 2/4] ipmi: Remove SPMI table based device discovery method Myron Stowe
2010-03-04  7:56   ` [Openipmi-developer] " Bela Lubkin
2010-03-04 18:47     ` Myron Stowe
2010-03-05 12:58       ` Bela Lubkin
2010-03-05 16:06         ` Bjorn Helgaas
2010-03-05 17:13         ` [Openipmi-developer] " Myron Stowe
2010-03-04  3:44 ` [PATCH 3/4] ipmi: Convert tracking of the ACPI device pointer to a PNP device Myron Stowe
2010-03-04  9:20   ` ykzhao
2010-03-04 20:48     ` Myron Stowe
2010-03-05  1:46       ` ykzhao
2010-03-05 16:41         ` Myron Stowe
2010-03-05 19:34           ` Bjorn Helgaas
2010-03-04  3:44 ` [PATCH 4/4] ipmi: Update driver to use 'dev_printk()' and its constructs Myron Stowe
2010-03-04 14:07 ` [PATCH 0/4] ipmi: remove SPMI and update core driver with dev_printk Corey Minyard
2010-03-05 16:31   ` Myron Stowe
2010-03-09 23:16   ` Myron Stowe
2010-03-10 14:55     ` [SPAM] - Re: [PATCH 0/4] ipmi: remove SPMI and update core driver with dev_printk - Email found in subject Andy Cress
2010-03-10 15:20       ` Corey Minyard
2010-03-10 17:55         ` [Openipmi-developer] " Myron Stowe
2010-03-11 17:10           ` Bela Lubkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100304034410.30205.13074.stgit@bob.kio \
    --to=myron.stowe@hp.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=minyard@acm.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.