All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Richter <robert.richter@amd.com>
To: eranian@google.com
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
	mingo@elte.hu, paulus@samba.org, fweisbec@gmail.com,
	perfmon2-devel@lists.sf.net, eranian@gmail.com,
	davem@davemloft.net
Subject: Re: [PATCH] perf_events: add sampling period randomization support (v2)
Date: Thu, 4 Mar 2010 09:52:56 +0100	[thread overview]
Message-ID: <20100304085256.GN13205@erda.amd.com> (raw)
In-Reply-To: <1267575705-10054-1-git-send-email-eranian@google.com>

On 02.03.10 16:21:45, eranian@google.com wrote:
> This patch adds support for randomizing the sampling period.  Randomization
> is very useful to mitigate the bias that exists with sampling. The random
> number generator does not need to be sophisticated. This patch uses the
> builtin random32() generator.
> 
> Randomization is activated by setting perf_event_attr.random_period_width
> to a non-zero value. It represents the width of the mask to apply to the
> random value, i.e, maximum range of variation. The random value is applied
> AROUND the period, i.e., period may be longer or shorter with a maximum
> variation of half the bit width. Thus, on average the sampling period remains
> equal to the initial period passed in perf_event_attr.sample_period.
> 
> Note that randomization is not available when a target interrupt rate
> (freq) is enabled.
> 
> The last used period can be collected using the PERF_SAMPLE_PERIOD flag
> in sample_type.
> 
> Randomization is implemented in generic code thus it applies to all
> PMU models and software events.
> 
> 	Signed-off-by: Stephane Eranian <eranian@google.com>
> 
> --
>  include/linux/perf_event.h |    3 +++
>  kernel/perf_event.c        |   44 ++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 47 insertions(+)

Reviewed-by: Robert Richter <robert.richter@amd.com>

-- 
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com


  reply	other threads:[~2010-03-04  8:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-03  0:21 [PATCH] perf_events: add sampling period randomization support (v2) eranian
2010-03-04  8:52 ` Robert Richter [this message]
2010-03-04 11:32 ` Ingo Molnar
2010-03-04 17:25   ` Stephane Eranian
2010-03-04 21:13     ` Ingo Molnar
2010-03-05  2:34       ` Stephane Eranian
2010-03-11 11:52         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100304085256.GN13205@erda.amd.com \
    --to=robert.richter@amd.com \
    --cc=davem@davemloft.net \
    --cc=eranian@gmail.com \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=perfmon2-devel@lists.sf.net \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.