From: "Michael S. Tsirkin" <mst@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: quintela@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCHv4 07/12] virtio: move typedef to qemu-common
Date: Thu, 4 Mar 2010 14:19:58 +0200 [thread overview]
Message-ID: <20100304121958.GA3047@redhat.com> (raw)
In-Reply-To: <20100304122019.GC8118@amit-x200.redhat.com>
On Thu, Mar 04, 2010 at 05:50:19PM +0530, Amit Shah wrote:
> On (Wed) Mar 03 2010 [19:16:28], Michael S. Tsirkin wrote:
> > make it possible to use type without header include
>
> Why?
So that vhost.h does not need to include virtio.h
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > hw/virtio.h | 1 -
> > qemu-common.h | 1 +
> > 2 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/hw/virtio.h b/hw/virtio.h
> > index 58b06bf..6f2fab0 100644
> > --- a/hw/virtio.h
> > +++ b/hw/virtio.h
> > @@ -69,7 +69,6 @@ static inline target_phys_addr_t vring_align(target_phys_addr_t addr,
> > }
> >
> > typedef struct VirtQueue VirtQueue;
> > -typedef struct VirtIODevice VirtIODevice;
> >
> > #define VIRTQUEUE_MAX_SIZE 1024
> >
> > diff --git a/qemu-common.h b/qemu-common.h
> > index f12a8f5..90ca3b8 100644
> > --- a/qemu-common.h
> > +++ b/qemu-common.h
> > @@ -228,6 +228,7 @@ typedef struct I2SCodec I2SCodec;
> > typedef struct DeviceState DeviceState;
> > typedef struct SSIBus SSIBus;
> > typedef struct EventNotifier EventNotifier;
> > +typedef struct VirtIODevice VirtIODevice;
> >
> > typedef uint64_t pcibus_t;
>
> Amit
next prev parent reply other threads:[~2010-03-04 12:23 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 17:15 [Qemu-devel] [PATCHv4 00/12] vhost-net: upstream integration Michael S. Tsirkin
2010-03-03 17:15 ` [Qemu-devel] [PATCHv4 01/12] tap: add interface to get device fd Michael S. Tsirkin
2010-03-03 17:15 ` [Qemu-devel] [PATCHv4 02/12] kvm: add API to set ioeventfd Michael S. Tsirkin
2010-03-03 17:16 ` [Qemu-devel] [PATCHv4 03/12] notifier: event notifier implementation Michael S. Tsirkin
2010-03-05 12:03 ` [Qemu-devel] " Amit Shah
2010-03-03 17:16 ` [Qemu-devel] [PATCHv4 04/12] virtio: add notifier support Michael S. Tsirkin
2010-03-05 12:04 ` [Qemu-devel] " Amit Shah
2010-03-03 17:16 ` [Qemu-devel] [PATCHv4 05/12] virtio: add APIs for queue fields Michael S. Tsirkin
2010-03-05 12:10 ` [Qemu-devel] " Amit Shah
2010-03-06 19:09 ` Michael S. Tsirkin
2010-03-05 13:08 ` Amit Shah
2010-03-06 19:07 ` Michael S. Tsirkin
2010-03-08 6:16 ` Amit Shah
2010-03-08 18:11 ` Michael S. Tsirkin
2010-03-03 17:16 ` [Qemu-devel] [PATCHv4 06/12] virtio: add set_status callback Michael S. Tsirkin
2010-03-04 12:19 ` Amit Shah
2010-03-04 12:20 ` Michael S. Tsirkin
2010-03-03 17:16 ` [Qemu-devel] [PATCHv4 07/12] virtio: move typedef to qemu-common Michael S. Tsirkin
2010-03-04 12:20 ` Amit Shah
2010-03-04 12:19 ` Michael S. Tsirkin [this message]
2010-03-04 12:29 ` Amit Shah
2010-03-04 12:31 ` Michael S. Tsirkin
2010-03-03 17:16 ` [Qemu-devel] [PATCHv4 08/12] virtio-pci: fill in notifier support Michael S. Tsirkin
2010-03-03 17:16 ` [Qemu-devel] [PATCHv4 09/12] vhost: vhost net support Michael S. Tsirkin
2010-03-05 18:19 ` [Qemu-devel] " Amit Shah
2010-03-06 19:06 ` Michael S. Tsirkin
2010-03-08 6:20 ` Amit Shah
2010-03-16 15:37 ` Michael S. Tsirkin
2010-03-17 4:09 ` Amit Shah
2010-03-03 17:16 ` [Qemu-devel] [PATCHv4 10/12] tap: add vhost/vhostfd options Michael S. Tsirkin
2010-03-03 17:16 ` [Qemu-devel] [PATCHv4 11/12] tap: add API to retrieve vhost net header Michael S. Tsirkin
2010-03-03 17:16 ` [Qemu-devel] [PATCHv4 12/12] virtio-net: vhost net support Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100304121958.GA3047@redhat.com \
--to=mst@redhat.com \
--cc=amit.shah@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.