Re: [RFT][PATCH] drm/radeon/kms: check for being in VBLANK on VBLANK interrupt

[Jaime Velasco Juan <jsagarribay@gmail.com>]

El mié. 03 de mar. de 2010, a las 23:35:00 +0100, Rafał Miłecki escribió:
> W dniu 3 marca 2010 23:33 użytkownik Rafał Miłecki <zajec5@gmail.com> napisał:
> > This is supposed to check if we receive correct interrupt and if out check for
> > VBLANK is correct. If you get warnings with patch applied, it means we have
> > problem in at least one of mentioned places.
> > ---
> > To provoke VBLANK interrupt appearing, please use dynpm and start/stop for
> > example glxgears few times.
> >
> > Jaime can you check this? I know you experienced warnings when using check in
> > PM code.
> >

Here are a few tests:

[  169.696784] [drm] Requested: e: 68000 m: 80000 p: 16
[  169.696802] [drm] Setting: e: 68000 m: 80000 p: 16
[  172.700046] [drm] Requested: e: 11000 m: 40500 p: 16
[  172.700055] [drm] Setting: e: 11000 m: 40500 p: 16
[  179.513370] [drm] Requested: e: 68000 m: 80000 p: 16 
[  179.513388] [drm] Setting: e: 68000 m: 80000 p: 16 
[  180.113380] [drm] Requested: e: 11000 m: 40500 p: 16 
[  180.113389] [drm] Setting: e: 11000 m: 40500 p: 16 
[  180.115295] [drm] not in vbl for pm change 00020002 00000000 at entry
[  184.513350] [drm] Requested: e: 68000 m: 80000 p: 16 
[  184.513359] [drm] Setting: e: 68000 m: 80000 p: 16 
[  186.023395] [drm] Requested: e: 11000 m: 40500 p: 16 
[  186.023403] [drm] Setting: e: 11000 m: 40500 p: 16 
[  192.040034] [drm] Requested: e: 68000 m: 80000 p: 16 
[  192.040054] [drm] Setting: e: 68000 m: 80000 p: 16 
[  193.946734] [drm] Requested: e: 11000 m: 40500 p: 16 
[  193.946743] [drm] Setting: e: 11000 m: 40500 p: 16 
[  230.163392] [drm] Requested: e: 68000 m: 80000 p: 16 
[  230.163411] [drm] Setting: e: 68000 m: 80000 p: 16 
[  231.473389] [drm] Requested: e: 11000 m: 40500 p: 16 
[  231.473398] [drm] Setting: e: 11000 m: 40500 p: 16 
[  327.796715] [drm] Requested: e: 68000 m: 80000 p: 16 
[  327.796734] [drm] Setting: e: 68000 m: 80000 p: 16 
[  328.496738] [drm] Requested: e: 11000 m: 40500 p: 16 
[  328.496746] [drm] Setting: e: 11000 m: 40500 p: 16 
[  328.497883] [drm] not in vbl for pm change 00020002 00000000 at entry

> > Dave: I believe you reported warnings as well?
> > ---
> 
> Personally I got following results on my machine:
> 
> [   57.981202] [drm] Requested: e: 68000 m: 80000 p: 16
> [   57.981212] [drm] Setting: e: 68000 m: 80000 p: 16
> [   57.982827] [drm] not in vbl for pm change 00020002 00000000 at entry
> [   61.784087] [drm] Requested: e: 11000 m: 40500 p: 16
> [   61.784095] [drm] Setting: e: 11000 m: 40500 p: 16
> [   61.799187] [drm] not in vbl for pm change 00020002 00000000 at entry
> [   66.799047] [drm] Requested: e: 68000 m: 80000 p: 16
> [   66.799056] [drm] Setting: e: 68000 m: 80000 p: 16
> [   69.916111] [drm] Requested: e: 11000 m: 40500 p: 16
> [   69.916119] [drm] Setting: e: 11000 m: 40500 p: 16
> [   69.931836] [drm] not in vbl for pm change 00020002 00000000 at entry
> [   73.032037] [drm] Requested: e: 68000 m: 80000 p: 16
> [   73.032046] [drm] Setting: e: 68000 m: 80000 p: 16
> [   76.048056] [drm] Requested: e: 11000 m: 40500 p: 16
> [   76.048064] [drm] Setting: e: 11000 m: 40500 p: 16
> [   78.964090] [drm] Requested: e: 68000 m: 80000 p: 16
> [   78.964099] [drm] Setting: e: 68000 m: 80000 p: 16
> [   84.864053] [drm] Requested: e: 11000 m: 40500 p: 16
> [   84.864069] [drm] Setting: e: 11000 m: 40500 p: 16
> [   84.864102] [drm] not in vbl for pm change 00010002 00000000 at entry
> [   93.165037] [drm] Requested: e: 68000 m: 80000 p: 16
> [   93.165046] [drm] Setting: e: 68000 m: 80000 p: 16
> [   98.080093] [drm] Requested: e: 11000 m: 40500 p: 16
> [   98.080102] [drm] Setting: e: 11000 m: 40500 p: 16
> [  101.396033] [drm] Requested: e: 68000 m: 80000 p: 16
> [  101.396041] [drm] Setting: e: 68000 m: 80000 p: 16
> [  105.012113] [drm] Requested: e: 11000 m: 40500 p: 16
> [  105.012121] [drm] Setting: e: 11000 m: 40500 p: 16
> [  107.613035] [drm] Requested: e: 68000 m: 80000 p: 16
> [  107.613044] [drm] Setting: e: 68000 m: 80000 p: 16
> [  111.728091] [drm] Requested: e: 11000 m: 40500 p: 16
> [  111.728099] [drm] Setting: e: 11000 m: 40500 p: 16
> [  114.328054] [drm] Requested: e: 68000 m: 80000 p: 16
> [  114.328063] [drm] Setting: e: 68000 m: 80000 p: 16
> [  114.328102] [drm] not in vbl for pm change 00020002 00000000 at entry
> [  119.328104] [drm] Requested: e: 11000 m: 40500 p: 16
> [  119.328117] [drm] Setting: e: 11000 m: 40500 p: 16
> [  119.344343] [drm] not in vbl for pm change 00020002 00000000 at entry
> 
> 
> So you can see I receive VBLANK when *not* being in VBLANK in about 50% cases.
> 
> I don't experience corruptions however.
> 
> -- 
> Rafał

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel