From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH] ACPI / PM: Move ACPI video resume to a PM notifier Date: Thu, 4 Mar 2010 20:12:36 +0100 Message-ID: <201003042012.36416.rjw@sisk.pl> References: <201003040125.30091.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: Text/Plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from ogre.sisk.pl ([217.79.144.158]:48973 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755274Ab0CDTJ5 convert rfc822-to-8bit (ORCPT ); Thu, 4 Mar 2010 14:09:57 -0500 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: =?utf-8?q?Rafa=C5=82_Mi=C5=82ecki?= Cc: Len Brown , Matthew Garrett , ACPI Devel Maling List , pm list , LKML On Thursday 04 March 2010, Rafa=C5=82 Mi=C5=82ecki wrote: > 2010/3/4 Rafael J. Wysocki : > > There is a problem with the ACPI video resume routine that it's > > executed before the GPU that may be accessed by it. To fix this > > issue, move the ACPI video resume to a power management notifier, > > so that it's executed after resuming all devices, including the GPU= =2E > > > > Signed-off-by: Rafael J. Wysocki > > --- >=20 > Tested-by: Rafa=C5=82 Mi=C5=82ecki Thanks! > It partially fixes bugzilla bug #15096 and it first needed step to fi= x > it completely. To fix that completely we'd need to avoid calling acpi_video_resume() i= n the non-KMS case, but it's not clear how to tell the ACPI driver which case= we're in. It's not certain how to reliably distinguish the KMS and non-KMS c= ases at this level in the first place. > Can we send this to stable for .32 and .33? That depends on Len. Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756818Ab0CDTJ7 (ORCPT ); Thu, 4 Mar 2010 14:09:59 -0500 Received: from ogre.sisk.pl ([217.79.144.158]:48973 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755274Ab0CDTJ5 convert rfc822-to-8bit (ORCPT ); Thu, 4 Mar 2010 14:09:57 -0500 From: "Rafael J. Wysocki" To: =?utf-8?q?Rafa=C5=82_Mi=C5=82ecki?= Subject: Re: [PATCH] ACPI / PM: Move ACPI video resume to a PM notifier Date: Thu, 4 Mar 2010 20:12:36 +0100 User-Agent: KMail/1.12.4 (Linux/2.6.33-git-rjw; KDE/4.3.5; x86_64; ; ) Cc: Len Brown , Matthew Garrett , ACPI Devel Maling List , pm list , LKML References: <201003040125.30091.rjw@sisk.pl> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Message-Id: <201003042012.36416.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 04 March 2010, Rafał Miłecki wrote: > 2010/3/4 Rafael J. Wysocki : > > There is a problem with the ACPI video resume routine that it's > > executed before the GPU that may be accessed by it. To fix this > > issue, move the ACPI video resume to a power management notifier, > > so that it's executed after resuming all devices, including the GPU. > > > > Signed-off-by: Rafael J. Wysocki > > --- > > Tested-by: Rafał Miłecki Thanks! > It partially fixes bugzilla bug #15096 and it first needed step to fix > it completely. To fix that completely we'd need to avoid calling acpi_video_resume() in the non-KMS case, but it's not clear how to tell the ACPI driver which case we're in. It's not certain how to reliably distinguish the KMS and non-KMS cases at this level in the first place. > Can we send this to stable for .32 and .33? That depends on Len. Rafael