From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, laijs@cn.fujitsu.com,
dipankar@in.ibm.com, akpm@linux-foundation.org,
mathieu.desnoyers@polymtl.ca, josh@joshtriplett.org,
dvhltc@us.ibm.com, niv@us.ibm.com, tglx@linutronix.de,
peterz@infradead.org, rostedt@goodmis.org,
Valdis.Kletnieks@vt.edu, dhowells@redhat.com
Subject: Re: [PATCH tip/core/rcu 2/4] rcu: suppress RCU lockdep warnings during early boot
Date: Thu, 4 Mar 2010 12:36:49 -0800 [thread overview]
Message-ID: <20100304203649.GJ6768@linux.vnet.ibm.com> (raw)
In-Reply-To: <20100304111245.GD21977@elte.hu>
On Thu, Mar 04, 2010 at 12:12:45PM +0100, Ingo Molnar wrote:
>
> * Paul E. McKenney <paulmck@linux.vnet.ibm.com> wrote:
>
> > @@ -154,6 +167,10 @@ static inline int rcu_read_lock_sched_held(void)
> > # define rcu_read_acquire_sched() do { } while (0)
> > # define rcu_read_release_sched() do { } while (0)
> >
> > +static inline void debug_lockdep_rcu_update(void)
> > +{
> > +}
> > +
>
> Note, this method was only included for the !CONFIG_DEBUG_LOCK_ALLOC case, so
> i left it out for the time being.
>
> Which may result in a somewhat incomplete debug state, but it would at least
> build with lockdep enabled ;-)
Indeed, I clearly didn't test with the boot-time lock testing enabled. :-/
Please accept my apologies for my mess-up, and thank you for fixing it!
Thanx, Paul
next prev parent reply other threads:[~2010-03-04 20:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 15:46 [PATCH tip/core/rcu 0/4] rcu: suppress RCU lockdep early-boot warnings and fixes Paul E. McKenney
2010-03-03 15:46 ` [PATCH tip/core/rcu 1/4] rcu: use wrapper function instead of exporting tasklist_lock Paul E. McKenney
2010-03-04 16:31 ` [tip:core/urgent] rcu: Use " tip-bot for Paul E. McKenney
2010-03-03 15:46 ` [PATCH tip/core/rcu 2/4] rcu: suppress RCU lockdep warnings during early boot Paul E. McKenney
2010-03-04 11:12 ` Ingo Molnar
2010-03-04 11:44 ` Ingo Molnar
2010-03-04 20:35 ` Paul E. McKenney
2010-03-04 20:36 ` Paul E. McKenney [this message]
2010-03-04 16:33 ` [tip:core/urgent] rcu: Suppress " tip-bot for Paul E. McKenney
2010-03-03 15:46 ` [PATCH tip/core/rcu 3/4] rcu: revert 1883c79a: early boot now handled by lockdep-RCU Paul E. McKenney
2010-03-04 16:32 ` [tip:core/urgent] rcu, cgroup: Relax the check in task_subsys_state() as early boot is " tip-bot for Paul E. McKenney
2010-03-03 15:46 ` [PATCH tip/core/rcu 4/4] rcu: add control variables to lockdep_rcu_dereference() diagnostics Paul E. McKenney
2010-03-04 16:32 ` [tip:core/urgent] rcu: Add " tip-bot for Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100304203649.GJ6768@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=dvhltc@us.ibm.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=niv@us.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.