All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@linux.intel.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-ide@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git patches] libata updates for 2.6.34
Date: Fri, 5 Mar 2010 18:37:24 +0000	[thread overview]
Message-ID: <20100305183724.37b6f820@linux.intel.com> (raw)
In-Reply-To: <201003051958.24987.bzolnier@gmail.com>

> > +		const struct ata_port_info * const * ppi,
> > +		struct scsi_host_template *sht, void *host_priv,
> > int hflags);
> 
> 'int' type is not equal 'unsigned long' one on 64-bit architectures.

Agreed should indeed be a ulong.

> Besides doing it this way is clearly suboptimal

In your opinion - see previous discussion of this.

  reply	other threads:[~2010-03-05 19:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-01 20:23 [git patches] libata updates for 2.6.34 Jeff Garzik
2010-03-05 18:58 ` Bartlomiej Zolnierkiewicz
2010-03-05 18:37   ` Alan Cox [this message]
2010-03-05 19:43   ` Jeff Garzik
2010-03-05 20:12     ` Bartlomiej Zolnierkiewicz
2010-03-09 21:17 ` Linus Torvalds
2010-03-09 22:12   ` Jeff Garzik
2010-03-10  4:26     ` Tejun Heo
2010-03-12  0:16       ` Jeff Garzik
2010-03-15  2:55       ` Jeff Garzik
2010-03-15  7:33         ` Zeno Davatz
2010-03-15 13:06           ` Jeff Garzik
2010-03-15 13:21             ` Zeno Davatz
2010-03-15 13:30               ` Zeno Davatz
2010-03-15 13:32               ` Jeff Garzik
2010-03-15 13:35                 ` Zeno Davatz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100305183724.37b6f820@linux.intel.com \
    --to=alan@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=bzolnier@gmail.com \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.