From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nndk9-0008PE-Fd for qemu-devel@nongnu.org; Fri, 05 Mar 2010 15:03:29 -0500 Received: from [199.232.76.173] (port=55117 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nndk8-0008Oh-Sz for qemu-devel@nongnu.org; Fri, 05 Mar 2010 15:03:28 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nndk7-0004xs-2q for qemu-devel@nongnu.org; Fri, 05 Mar 2010 15:03:28 -0500 Received: from hall.aurel32.net ([88.191.82.174]:33098) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Nndk6-0004xf-N1 for qemu-devel@nongnu.org; Fri, 05 Mar 2010 15:03:26 -0500 Received: from [2a01:e35:2e80:2fb0:21e:8cff:feb0:693b] (helo=volta.aurel32.net) by hall.aurel32.net with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1Nndk5-0005xL-7p for qemu-devel@nongnu.org; Fri, 05 Mar 2010 21:03:25 +0100 Received: from aurel32 by volta.aurel32.net with local (Exim 4.71) (envelope-from ) id 1Nndjy-0000FO-B5 for qemu-devel@nongnu.org; Fri, 05 Mar 2010 21:03:18 +0100 Date: Fri, 5 Mar 2010 21:03:18 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] Re: Regression: segfault on ARM host Message-ID: <20100305200318.GV10291@volta.aurel32.net> References: <20100301213351.GN8952@hall.aurel32.net> <4B8C40B3.6030008@redhat.com> <20100302000529.GO8952@hall.aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20100302000529.GO8952@hall.aurel32.net> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel On Tue, Mar 02, 2010 at 01:05:29AM +0100, Aurelien Jarno wrote: > On Mon, Mar 01, 2010 at 11:33:23PM +0100, Paolo Bonzini wrote: > > On 03/01/2010 10:33 PM, Aurelien Jarno wrote: > >> While trying to implement setcond on TCG ARM, I have discovered it does > >> not work anymore. I have bisected this regression to: > >> > >> commit 6113d6d3169393c323ac4c82d756a850145a5e7a > >> Author: Paolo Bonzini > >> Date: Fri Jan 15 09:42:09 2010 +0100 > >> > >> change while to if > >> > >> The while loop will be executed exactly 0 or 1 times, depending on > >> env->exit_request. > >> > >> Signed-off-by: Paolo Bonzini > >> Signed-off-by: Anthony Liguori > >> > >> The assertion is actually triggered. When the next patch removing the > >> assertion is also applied it segfaults instead. > > > > Looks like a race. The only piece of logic that is changed by that > > commit is reverted in the attached patch, can you try it? If it passes, > > I can resubmit with S-o-b. > > Unfortunately it doesn't work. > The bug is actually in the ARM backend, I have just send a patch on the mailing list to fix it. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net