From: "John W. Linville" <linville@tuxdriver.com>
To: Kalle Valo <kalle.valo@iki.fi>
Cc: Sujith <Sujith.Manoharan@atheros.com>,
Pavel Roskin <proski@gnu.org>,
"Luis R. Rodriguez" <mcgrof@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Vasanth Thiagarajan <Vasanth.Thiagarajan@Atheros.com>,
Senthilkumar Balasubramanian
<Senthilkumar.Balasubramanian@Atheros.com>
Subject: Re: [PATCH] ath9k_htc: Add ath9k_htc driver
Date: Sat, 6 Mar 2010 10:54:51 -0500 [thread overview]
Message-ID: <20100306155451.GA3595@tuxdriver.com> (raw)
In-Reply-To: <87hboteaia.fsf@purkki.valot.fi>
On Sat, Mar 06, 2010 at 05:27:09PM +0200, Kalle Valo wrote:
> Sujith <Sujith.Manoharan@atheros.com> writes:
>
> >> The original patch should be run through checkpatch.pl. In addition to
> >> overly long lines, there are some other formatting issues.
> >
> > I thought that the default was 106 (or 132 ?) these days ..
>
> From CodingStyle:
>
> "The limit on the length of lines is 80 columns and this is a strongly
> preferred limit."
>
> And I fully agree with that. It's easier to read code that way.
ACK
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-03-06 15:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-26 10:56 [PATCH] ath9k_htc: Add ath9k_htc driver Sujith
2010-02-26 18:33 ` Pavel Roskin
2010-02-26 18:42 ` Luis R. Rodriguez
2010-02-27 1:19 ` Pavel Roskin
2010-02-27 5:29 ` Sujith
2010-03-06 15:27 ` Kalle Valo
2010-03-06 15:54 ` John W. Linville [this message]
2010-02-27 6:09 ` Sujith
2010-02-27 5:24 ` Sujith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100306155451.GA3595@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Senthilkumar.Balasubramanian@Atheros.com \
--cc=Sujith.Manoharan@atheros.com \
--cc=Vasanth.Thiagarajan@Atheros.com \
--cc=kalle.valo@iki.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.