From: Dan Carpenter <error27@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: telephony: precendence issue
Date: Mon, 08 Mar 2010 12:16:36 +0000 [thread overview]
Message-ID: <20100308121636.GH6469@bicker> (raw)
drivers/telephony/ixj.c +6834 ixj_selfprobe(67)
6833 case QTI_PHONEJACK:
6834 if (!j->dsp.low != 0x20) {
6835 j->dsp.high = 0x80;
6836 j->dsp.low = 0x20;
"!" has precedence over "!=" and since both 1 and 0 are not equal
to 0x20 the condition is always true.
I'm pretty sure the "!" is a stray and the test should be:
if (j->dsp.low != 0x20) {
but I don't have the hardware to test this.
regards,
dan carpenter
reply other threads:[~2010-03-08 12:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100308121636.GH6469@bicker \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.