From: Thomas Renninger <trenn@suse.de>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Kerstin Jonsson <kerstin.jonsson@ericsson.com>,
jbohac@novell.com, Yinghai Lu <yinghai@kernel.org>,
akpm@linux-foundation.org, mingo@elte.hu,
Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] x86 apic: Ack all pending irqs when crashed/on kexec
Date: Mon, 8 Mar 2010 12:40:03 +0100 [thread overview]
Message-ID: <201003081240.03265.trenn@suse.de> (raw)
In-Reply-To: <20100308113452.GK6004@lenovo>
On Monday 08 March 2010 12:34:52 Cyrill Gorcunov wrote:
> On Mon, Mar 08, 2010 at 12:17:10PM +0100, Thomas Renninger wrote:
> ...
> > diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
> > index 3987e44..93cdb2a 100644
> > + if (cpu_has_tsc)
> > + rdtscll(ntsc);
>
> Perhaps rdtscll(tsc)?
Oh dear..., I played with this to wipe out:
warning: ‘tsc’ may be used uninitialized in this function
> > + if (cpu_has_tsc) {
> > + rdtscll(ntsc);
> > + max_loops = (cpu_khz << 10) - (ntsc - tsc);
>
> Where is tsc modified? It remains tsc = 0 all the time?
> Or I miss the snippet where it is set?
Yes, you are right..., next version, thanks a lot for looking at this,
Thomas
next prev parent reply other threads:[~2010-03-08 11:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 11:17 [PATCH] x86 apic: Ack all pending irqs when crashed/on kexec Thomas Renninger
2010-03-08 11:26 ` Avi Kivity
2010-03-08 11:34 ` [PATCH] x86 apic: Ack all pending irqs when crashed/on kexec - V3 Thomas Renninger
2010-03-08 11:26 ` [PATCH] x86 apic: Ack all pending irqs when crashed/on kexec Thomas Renninger
2010-03-08 11:34 ` Cyrill Gorcunov
2010-03-08 11:40 ` Thomas Renninger [this message]
2010-03-08 11:43 ` [PATCH] x86 apic: Ack all pending irqs when crashed/on kexec - V4 Thomas Renninger
2010-03-08 16:25 ` Kerstin Jonsson
2010-03-09 9:14 ` kerstin.jonsson
2010-03-09 10:52 ` [PATCH] x86 apic: Ack all pending irqs when crashed/on kexec - V5 Thomas Renninger
2010-03-19 1:18 ` Eric W. Biederman
2010-03-20 6:42 ` Eric W. Biederman
2010-03-22 11:28 ` kerstin.jonsson
2010-03-22 12:23 ` Eric W. Biederman
[not found] ` <43F901BD926A4E43B106BF17856F0755E7C393B9@orsmsx508.amr.corp.intel.com>
2010-06-17 0:19 ` H. Peter Anvin
2010-06-17 1:51 ` Eric W. Biederman
[not found] ` <43F901BD926A4E43B106BF17856F0755E7C3985D@orsmsx508.amr.corp.intel.com>
2010-06-17 17:00 ` H. Peter Anvin
-- strict thread matches above, loose matches on Subject: below --
2010-02-23 11:51 [PATCH] x86 apic: Ack all pending irqs when crashed/on kexec Thomas Renninger
2010-02-23 12:01 ` Thomas Renninger
2010-02-23 12:03 ` Avi Kivity
2010-02-26 19:47 ` Kerstin Jonsson
2010-03-08 10:18 ` Avi Kivity
[not found] <1266357790-8962-1-git-send-email-trenn@suse.de>
2010-02-17 16:05 ` Jiri Bohac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003081240.03265.trenn@suse.de \
--to=trenn@suse.de \
--cc=akpm@linux-foundation.org \
--cc=avi@redhat.com \
--cc=gorcunov@gmail.com \
--cc=jbohac@novell.com \
--cc=kerstin.jonsson@ericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.