All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Steve Dickson <SteveD@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] mountd: fix --manage-gids hang due to int/uint bug
Date: Mon, 8 Mar 2010 11:28:44 -0500	[thread overview]
Message-ID: <20100308162844.GA31579@fieldses.org> (raw)
In-Reply-To: <4B95249C.9020306-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>

On Mon, Mar 08, 2010 at 11:23:56AM -0500, Steve Dickson wrote:
> 
> 
> On 03/02/2010 03:49 PM, J. Bruce Fields wrote:
> > From: J. Bruce Fields <bfields@citi.umich.edu>
> > 
> > A uid or gid should be represented as unsigned, not signed.
> > 
> > The conversion to signed here could cause a hang on access by an unknown
> > user to a server running mountd with --manage-gids; such a user is
> > likely to be mapped to 232-1, which may be converted to 231-1 when
> > represented as an int, resulting in a downcall for uid 231-1, hence the
> > original rpc hanging forever waiting for a cache downcall for 232-1.
> > 
> > Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
> Committed... 

Thanks.

But, that's really weird: where did all the carat's (^'s) go, in 2^32
and 2^31?

--b.

      parent reply	other threads:[~2010-03-08 16:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-02 20:49 [PATCH] mountd: fix --manage-gids hang due to int/uint bug J. Bruce Fields
2010-03-08 16:23 ` Steve Dickson
     [not found]   ` <4B95249C.9020306-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2010-03-08 16:28     ` J. Bruce Fields [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100308162844.GA31579@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=SteveD@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.