Re: [PATCH 1/2] quota: merge __dquot_transfer into dquot_transfer

[Jan Kara <jack@suse.cz>]

On Mon 08-03-10 12:42:07, Christoph Hellwig wrote:
> On Mon, Mar 08, 2010 at 06:39:28PM +0100, Jan Kara wrote:
> > > Dmitri will have to add code to grab the project ID somewhere.  His
> > > patch made that easier when the two functions were split over an
> > > indirect call boundary, but now that this is gone it's not needed
> > > anymore.  One line still needs to be added, and that's in the ne
> > > dquot_transfer.
> >   Hmm, but dquot_transfer gets new uid/gid from struct iattr. So either
> > we have to extend struct iattr to accompany also project_id changes (fine
> > with me) or we have to keep interface similar to __dquot_transfer. Do
> > you have any preference?
> 
> If we promote the project ID to a first level VFS object like the
> last series does we should also add it to struct iattr.  Anyway, I need
  OK, that would make sence.

> to look through the project ID patches in more detail, I'm not quite
> happy yet with what I saw from quickly skipping over them.  I'll try to
> get back to it tomorrow.
  OK, I'll wait for a few days to see what you and Dmitry to agree on
before merging the patch. We are not in any hurry now...

								Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR