From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [PATCH 0/12][user-cr]: Second set of cleanups Date: Mon, 8 Mar 2010 13:49:23 -0600 Message-ID: <20100308194923.GC20030@us.ibm.com> References: <20100305223439.GA15300@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20100305223439.GA15300-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Sukadev Bhattiprolu Cc: Containers , sukadev-6JnAsaTVvkgX0ybBhKVfKdBPR1lH4CV8@public.gmane.org List-Id: containers.vger.kernel.org Quoting Sukadev Bhattiprolu (sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org): > > Second set of cleanup patches. With these patches, LXC will be able > to compile/link directly using restart.o and app-checkpoint.h from > the user-cr directory. Something like: > > USER_CR=/home/suka/user-cr make lxc_restart > > After having more detailed discussions on the API, we could install > restart.o in /lib/libcheckpoint.a and app-checkpoint.h in /usr/include. > > [PATCH 01/12][user-cr] restart: Mark globals as static > [PATCH 02/12][user-cr] restart: Add args->send_sigint > [PATCH 03/12][user-cr] Add app_restart_args->debug > [PATCH 04/12][user-cr] Add app_restart_args->verbose > [PATCH 05/12][user-cr] Add app_restart_args->ulogfd > [PATCH 06/12][user-cr] Add app_restart_args->uerrfd > [PATCH 07/12][user-cr] Define INIT_SIGNAL_ARRAY > [PATCH 08/12][user-cr] Create common.h > [PATCH 09/12][user-cr] Create app-checkpoint.h > [PATCH 10/12][user-cr] restart: Move main() to restart-main.c > [PATCH 11/12][user-cr] checkpoint: Move main() to checkpoint-main.c > [PATCH 12/12][user-cr] Have app_restart() return pid > > Signed-off-by: Sukadev Bhattiprolu Again, not yet tested (though will do that soon as I will base my mounts c/r patchset on ckpt-v19-suka), but looks good, thanks. Acked-by: Serge Hallyn -serge