From: Al Viro <viro@ZenIV.linux.org.uk>
To: wzt.wzt@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-audit@redhat.com,
eparis@redhat.com, faith@redhat.com
Subject: Re: [PATCH] Kernel: Fix coding style in kernel/audit.c
Date: Mon, 8 Mar 2010 20:44:00 +0000 [thread overview]
Message-ID: <20100308204359.GN30031@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20100308222742.GB17489@localhost.localdomain>
On Tue, Mar 09, 2010 at 06:27:42AM +0800, wzt.wzt@gmail.com wrote:
> Fix coding style in kernel/audit.c
>
> Signed-off-by: Zhitong Wang <zhitong.wangzt@alibaba-inc.com>
NACKed-by: Al Viro <viro@zeniv.linux.org.uk>
NACKed-because: get a life
> static int audit_set_enabled(int state, uid_t loginuid, u32 sessionid, u32 sid)
> {
> int rc;
> +
> if (state < AUDIT_OFF || state > AUDIT_LOCKED)
> return -EINVAL;
>
> rc = audit_do_config_change("audit_enabled", &audit_enabled, state,
> loginuid, sessionid, sid);
> -
> if (!rc)
> audit_ever_enabled |= !!state;
Seriously, people, please stop that masturbation.
next prev parent reply other threads:[~2010-03-08 20:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 22:27 [PATCH] Kernel: Fix coding style in kernel/audit.c wzt.wzt
2010-03-08 15:16 ` Alexey Dobriyan
2010-03-08 20:44 ` Al Viro [this message]
2010-03-08 20:56 ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100308204359.GN30031@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=eparis@redhat.com \
--cc=faith@redhat.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wzt.wzt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.