Re: Commit 0c8219f0... breaks omap7xx support

[Tony Lindgren <tony@atomide.com>]

* Cory Maccarrone <darkstar6262@gmail.com> [100306 20:53]:
> All,
> 
> I've finally gotten some time to test the latest linux-omap code, and
> found the following commit:
> 
>     4f2c49fedf... omap: Clean the serial port defines
> 
> breaks current omap7xx support.  To get linux-omap master to boot, I
> had to revert that, and the three two that follow it:
> 
>     0c8219f03... omap: Make uncompress code and DEBUG_LL code generic
>     61b603b4e...omap: Remove old DEBUG_LL serial port options
> 
> in order to boot with DEBUG_LL enabled.  Disabled, I only needed to
> revert the last two.

Hmm OK thanks for bisecting this. The first patch seems to have
a bug for uncompress.h on non omap3 platforms, see the attached
patch.

Are you sure you have CONFIG_EARLY_PRINTK and earlyprintk also
in your cmdline?

> I don't know enough about that part of the kernel to debug it, so all
> I can offer is a test result.  For reference, this was on
> board-htcherald using the htcherald_defconfig settings.

Can you try the following:

- Use the current mainline kernel head
- make sure you have DEBUG_LL and EARLY_PRINTK enabled in your .config
- check that you have earlyprintk also in the kernel cmdline
- no other serial patches applied

If no serial output, please temporarily hardcode the values
for your 7xx board in mach-omap1/include/mach/debug-macro.S for
omap_uart_phys and omap_uart_virt. Maybe that will give some
more clues.

If you don't have any serial output with that, then try this:

- reset some branch to 4f2c49fedf
- make sure you have DEBUG_LL and EARLY_PRINTK enabled in your .config
- check that you have earlyprintk also in the kernel cmdline
- apply the following patch for the uncompress code

That way you might be able to track down further where things
break with the patches following 4f2c49fedf.

Regards,

Tony

--- a/arch/arm/plat-omap/include/plat/uncompress.h
+++ b/arch/arm/plat-omap/include/plat/uncompress.h
@@ -42,11 +42,11 @@ static void putc(int c)
 #ifdef CONFIG_ARCH_OMAP
 	/* Will get removed in the next patch, set to OMAP3 to compile */
 #ifdef	CONFIG_OMAP_LL_DEBUG_UART3
-	uart = (volatile u8 *)(OMAP3_UART3_BASE);
+	uart = (volatile u8 *)(OMAP1_UART3_BASE);
 #elif defined(CONFIG_OMAP_LL_DEBUG_UART2)
-	uart = (volatile u8 *)(OMAP3_UART2_BASE);
+	uart = (volatile u8 *)(OMAP1_UART2_BASE);
 #elif defined(CONFIG_OMAP_LL_DEBUG_UART1)
-	uart = (volatile u8 *)(OMAP3_UART1_BASE);
+	uart = (volatile u8 *)(OMAP1_UART1_BASE);
 #elif defined(CONFIG_OMAP_LL_DEBUG_NONE)
 	return;
 #else