All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruno Randolf <br1@einfach.org>
To: jorge@dti2.net
Cc: me@bobcopeland.com, linville@tuxdriver.com, 8an@praha12.net,
	ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
	mickflemm@gmail.com, benoit.papillault@free.fr
Subject: Re: [PATCH v2] ath5k: fix I/Q calibration (for real)
Date: Tue, 9 Mar 2010 09:24:35 +0900	[thread overview]
Message-ID: <201003090924.35470.br1@einfach.org> (raw)
In-Reply-To: <4B94F183.2080002@dti2.net>

On Monday 08 March 2010 21:45:55 Jorge Boncompte [DTI2] wrote:
> El 08/03/2010 3:59, Bruno Randolf escribió:
> > 4.) we can't use ENABLE_BITS when we want to write a number (the number
> > can contain zeros). also always write the correction values first and
> > set ENABLE bit last, like the HAL does.
> 
> 	Hi Bruno,
> 
> 	does not ath5k_hw_commit_eeprom_settings() have the same problem 
described
> above when committing the IQ values from the EEPROM? legacy-hal does
> differently too.

yes, but i have fixed that in the second patch of this series:

[PATCH 2/3] ath5k: read eeprom IQ calibration values correctly for G mode

i forgot to mention that in the changelog.

bruno

  reply	other threads:[~2010-03-09  0:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-08  2:59 [PATCH v2] ath5k: fix I/Q calibration (for real) Bruno Randolf
2010-03-08  3:56 ` Luis R. Rodriguez
2010-03-08  4:17   ` [ath5k-devel] " Bruno Randolf
2010-03-08 16:24     ` Luis R. Rodriguez
2010-03-09  0:34       ` Bruno Randolf
2010-03-09  0:47         ` Luis R. Rodriguez
2010-03-09  0:50           ` Bruno Randolf
2010-03-09  1:21             ` Luis R. Rodriguez
2010-03-09  3:10               ` Bob Copeland
2010-03-09  3:32                 ` Luis R. Rodriguez
2010-03-09  5:56                   ` Bruno Randolf
2010-03-09  6:45                     ` Bob Copeland
2010-03-08 12:45 ` Jorge Boncompte [DTI2]
2010-03-09  0:24   ` Bruno Randolf [this message]
2010-03-09  0:33     ` Jorge Boncompte [DTI2]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201003090924.35470.br1@einfach.org \
    --to=br1@einfach.org \
    --cc=8an@praha12.net \
    --cc=ath5k-devel@lists.ath5k.org \
    --cc=benoit.papillault@free.fr \
    --cc=jorge@dti2.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=me@bobcopeland.com \
    --cc=mickflemm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.