From: Ralf Baechle <ralf@linux-mips.org>
To: David Daney <ddaney@caviumnetworks.com>
Cc: Yang Shi <yang.shi@windriver.com>,
f.fainelli@gmail.com, linux-mips@linux-mips.org
Subject: Re: [PATCH 3/3] MIPS: Octeon: Add add_wired_entry decralation in header file
Date: Tue, 9 Mar 2010 15:16:06 +0100 [thread overview]
Message-ID: <20100309141605.GA30829@linux-mips.org> (raw)
In-Reply-To: <4B8EA94B.1020203@caviumnetworks.com>
On Wed, Mar 03, 2010 at 10:24:11AM -0800, David Daney wrote:
> On 03/03/2010 12:43 AM, Yang Shi wrote:
> >Octeon's setup.c uses add_wired_entry, but it is not declared
> >anywhere. Copy add_wired_entry decralation from pgtable-32.h to
> >pgtable-64.h and include asm/pgtable.h into Octeon's setup.c.
> >
> >Signed-off-by: Yang Shi<yang.shi@windriver.com>
>
> NAK!
>
> We are removing the use of add_wired_entry(), so adding a
> declaration will not be necessary.
For explanation - add_wired_entry is a horrible API; it requires the user
to have knowledge about the TLB structure, code differently for 32-bit and
64-bit kernels. It's just the API of terror.
Ralf
next prev parent reply other threads:[~2010-03-09 14:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 8:43 [V2] Octeon: Several misc fixes Yang Shi
2010-03-03 8:43 ` [PATCH 1/3] MIPS: Octeon: Remove superfluous on_each_cpu parameter Yang Shi
2010-03-03 8:43 ` [PATCH 2/3] MIPS: Octeon: Remove redundant declaration of octeon_reserve32_memory Yang Shi
2010-03-03 18:25 ` David Daney
2010-03-11 0:52 ` Ralf Baechle
2010-03-03 8:43 ` [PATCH 3/3] MIPS: Octeon: Add add_wired_entry decralation in header file Yang Shi
2010-03-03 18:24 ` David Daney
2010-03-09 14:16 ` Ralf Baechle [this message]
2010-03-03 17:53 ` [PATCH 1/3] MIPS: Octeon: Remove superfluous on_each_cpu parameter David Daney
2010-03-04 2:08 ` Yang Shi
-- strict thread matches above, loose matches on Subject: below --
2010-03-03 7:26 Octeon: Several misc fixes Yang Shi
2010-03-03 7:26 ` [PATCH 2/3] MIPS: Octeon: Remove redundant declaration of octeon_reserve32_memory Yang Shi
2010-03-03 7:26 ` [PATCH 1/3] MIPS: Octeon: Remove superfluous on_each_cpu parameter Yang Shi
2010-03-03 7:26 ` [PATCH 3/3] MIPS: Octeon: Add add_wired_entry decralation in header file Yang Shi
2010-03-03 8:19 ` Florian Fainelli
2010-03-03 8:25 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100309141605.GA30829@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=ddaney@caviumnetworks.com \
--cc=f.fainelli@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=yang.shi@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.