From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754464Ab0CIOdP (ORCPT ); Tue, 9 Mar 2010 09:33:15 -0500 Received: from cantor.suse.de ([195.135.220.2]:41413 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753888Ab0CIOdK (ORCPT ); Tue, 9 Mar 2010 09:33:10 -0500 Date: Tue, 9 Mar 2010 06:18:01 -0800 From: Greg KH To: Valdis.Kletnieks@vt.edu Cc: Tejun Heo , Yinghai Lu , "Eric W. Biederman" , Peter Zijlstra , Andrew Morton , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: odd lockdep messages Message-ID: <20100309141801.GB28606@suse.de> References: <24605.1268073053@localhost> <1268073831.4997.69.camel@laptop> <4B95AA4C.2030303@kernel.org> <4298.1268116039@localhost> <4B95EE4C.3020606@kernel.org> <5221.1268124692@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5221.1268124692@localhost> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 09, 2010 at 03:51:32AM -0500, Valdis.Kletnieks@vt.edu wrote: > On Tue, 09 Mar 2010 15:44:28 +0900, Tejun Heo said: > > (adding some cc: from the other 'BUG: key %p not found' thread) > > > Hmm... the original percpu address check wasn't correct but wasn't too > > far off either so it wouldn't be surprising nothing triggered it. > > Yeap, stack trace should tell us where the address is coming from. > > OK, I stuck in a dump_stack(), and took out the built-in firmware so we'd > get 4 hits rather than 2. What we got: > > [ 1.007551] BUG: key ffff88011c8b7d00 not in .data! > [ 1.007657] Pid: 1, comm: swapper Not tainted 2.6.33-mmotm0304 #5 > [ 1.007763] Call Trace: > [ 1.007869] [] lockdep_init_map+0xab/0x10d > [ 1.007977] [] sysfs_add_file_mode+0x61/0xa7 > [ 1.008095] [] sysfs_add_file+0xc/0xe > [ 1.008201] [] sysfs_create_file+0x5a/0x63 > [ 1.008320] [] device_create_file+0x14/0x16 > [ 1.008428] [] thermal_zone_device_register+0x3d2/0x63c > [ 1.008538] [] acpi_thermal_add+0x2dc/0x59f > [ 1.008646] [] acpi_device_probe+0x4b/0x11d > [ 1.008753] [] driver_probe_device+0xd5/0x166 > [ 1.008861] [] __driver_attach+0x5c/0x80 > [ 1.008968] [] ? __driver_attach+0x0/0x80 > [ 1.009079] [] ? __driver_attach+0x0/0x80 > [ 1.009185] [] bus_for_each_dev+0x54/0x89 > [ 1.009301] [] driver_attach+0x19/0x1b > [ 1.009407] [] bus_add_driver+0xb4/0x203 > [ 1.009513] [] driver_register+0xb8/0x129 > [ 1.009621] [] ? acpi_thermal_init+0x0/0x7b > [ 1.009727] [] acpi_bus_register_driver+0x3e/0x40 > [ 1.009835] [] acpi_thermal_init+0x59/0x7b > [ 1.009942] [] do_one_initcall+0x59/0x14e > [ 1.010064] [] kernel_init+0x14d/0x1d7 > [ 1.010171] [] kernel_thread_helper+0x4/0x10 > [ 1.010289] [] ? restore_args+0x0/0x30 > [ 1.010394] [] ? kernel_init+0x0/0x1d7 > [ 1.010500] [] ? kernel_thread_helper+0x0/0x10 > > [ 1.010607] BUG: key ffff88011c8b7d48 not in .data! > [ 1.010711] Pid: 1, comm: swapper Not tainted 2.6.33-mmotm0304 #5 > [ 1.010817] Call Trace: > [ 1.010919] [] lockdep_init_map+0xab/0x10d > [ 1.011030] [] sysfs_add_file_mode+0x61/0xa7 > [ 1.011138] [] sysfs_add_file+0xc/0xe > [ 1.011243] [] sysfs_create_file+0x5a/0x63 > [ 1.011360] [] device_create_file+0x14/0x16 > [ 1.011467] [] thermal_zone_device_register+0x451/0x63c > [ 1.011576] [] acpi_thermal_add+0x2dc/0x59f > [ 1.011683] [] acpi_device_probe+0x4b/0x11d > [ 1.011790] [] driver_probe_device+0xd5/0x166 > [ 1.011897] [] __driver_attach+0x5c/0x80 > [ 1.012003] [] ? __driver_attach+0x0/0x80 > [ 1.012114] [] ? __driver_attach+0x0/0x80 > [ 1.012221] [] bus_for_each_dev+0x54/0x89 > [ 1.012340] [] driver_attach+0x19/0x1b > [ 1.012446] [] bus_add_driver+0xb4/0x203 > [ 1.012553] [] driver_register+0xb8/0x129 > [ 1.012659] [] ? acpi_thermal_init+0x0/0x7b > [ 1.012766] [] acpi_bus_register_driver+0x3e/0x40 > [ 1.012874] [] acpi_thermal_init+0x59/0x7b > [ 1.012980] [] do_one_initcall+0x59/0x14e > [ 1.013092] [] kernel_init+0x14d/0x1d7 > [ 1.013197] [] kernel_thread_helper+0x4/0x10 > [ 1.013314] [] ? restore_args+0x0/0x30 > [ 1.013421] [] ? kernel_init+0x0/0x1d7 > [ 1.013526] [] ? kernel_thread_helper+0x0/0x10 > > [ 2.859634] BUG: key ffff88011fe16270 not in .data! > [ 2.859654] Pid: 828, comm: firmware/iwlwif Not tainted 2.6.33-mmotm0304 #5 > [ 2.859656] Call Trace: > [ 2.859665] [] lockdep_init_map+0xab/0x10d > [ 2.859669] [] sysfs_add_file_mode+0x61/0xa7 > [ 2.859672] [] sysfs_add_file+0xc/0xe > [ 2.859675] [] sysfs_create_bin_file+0x5a/0x63 > [ 2.859680] [] _request_firmware+0x421/0x431 > [ 2.859683] [] ? request_firmware_work_func+0x0/0x63 > [ 2.859686] [] request_firmware_work_func+0x3a/0x63 > [ 2.859690] [] kthread+0x7a/0x82 > [ 2.859694] [] kernel_thread_helper+0x4/0x10 > [ 2.859699] [] ? restore_args+0x0/0x30 > [ 2.859702] [] ? kthread+0x0/0x82 > [ 2.859704] [] ? kernel_thread_helper+0x0/0x10 > > [ 11.534112] BUG: key ffff88011fe16270 not in .data! > [ 11.534116] Pid: 1556, comm: firmware/iwlwif Not tainted 2.6.33-mmotm0304 #5 > [ 11.534118] Call Trace: > [ 11.534128] [] lockdep_init_map+0xab/0x10d > [ 11.534133] [] sysfs_add_file_mode+0x61/0xa7 > [ 11.534137] [] sysfs_add_file+0xc/0xe > [ 11.534141] [] sysfs_create_bin_file+0x5a/0x63 > [ 11.534151] [] ? request_firmware_work_func+0x0/0x63 > [ 11.534147] [] _request_firmware+0x421/0x431 > [ 11.534154] [] request_firmware_work_func+0x3a/0x63 > [ 11.534159] [] kthread+0x7a/0x82 > [ 11.534164] [] kernel_thread_helper+0x4/0x10 > [ 11.534169] [] ? restore_args+0x0/0x30 > [ 11.534173] [] ? kthread+0x0/0x82 > [ 11.534176] [] ? kernel_thread_helper+0x0/0x10 > > So yeah, this looks like more sysfs breakage. It is due to sysfs, but it is because we forgot to proper initialize a sysfs attribute somewhere. Nothing is "broken" here, the system still works properly. Eric, care to look into this one as well? thanks, greg k-h