From: Oleg Nesterov <oleg@redhat.com>
To: Ingo Molnar <mingo@elte.hu>, Lai Jiangshan <laijs@cn.fujitsu.com>,
Peter Zijlstra <peterz@infradead.org>, Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Q: select_fallback_rq() && cpuset_lock()
Date: Tue, 9 Mar 2010 19:06:15 +0100 [thread overview]
Message-ID: <20100309180615.GA11681@redhat.com> (raw)
Hello.
I tried to remove the deadlockable cpuset_lock() many times, but my
attempts were ignored by cpuset maintainers ;)
In particular, see http://marc.info/?l=linux-kernel&m=125261083613103
But now I have another question. Since 5da9a0fb673a0ea0a093862f95f6b89b3390c31e
cpuset_cpus_allowed_locked() is called without callback_mutex held by
try_to_wake_up().
And, without callback_mutex held, isn't it possible to race with, say,
update_cpumask() which changes cpuset->cpus_allowed? Yes, update_tasks_cpumask()
should fixup task->cpus_allowed later. But isn't it possible (at least
in theory) that try_to_wake_up() gets, say, all-zeroes in task->cpus_allowed
after select_fallback_rq()->cpuset_cpus_allowed_locked() if we race with
update_cpumask()->cpumask_copy() ?
Oleg.
next reply other threads:[~2010-03-09 18:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-09 18:06 Oleg Nesterov [this message]
2010-03-10 16:40 ` Q: select_fallback_rq() && cpuset_lock() Peter Zijlstra
2010-03-10 17:30 ` Oleg Nesterov
2010-03-10 18:01 ` Peter Zijlstra
2010-03-10 18:33 ` Oleg Nesterov
2010-03-11 14:52 ` Oleg Nesterov
2010-03-11 15:22 ` Oleg Nesterov
2010-03-11 15:41 ` Peter Zijlstra
2010-03-11 15:35 ` Peter Zijlstra
2010-03-11 16:19 ` Oleg Nesterov
2010-03-11 16:29 ` Peter Zijlstra
2010-03-13 19:28 ` Oleg Nesterov
2010-03-14 2:11 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100309180615.GA11681@redhat.com \
--to=oleg@redhat.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.