All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -mm 1/3] call_usermodehelper: no need to unblock the signals
@ 2010-03-09 21:44 Oleg Nesterov
  0 siblings, 0 replies; only message in thread
From: Oleg Nesterov @ 2010-03-09 21:44 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Andi Kleen, David Howells, Neil Horman, Rusty Russell,
	linux-kernel

____call_usermodehelper() correctly calls flush_signal_handlers()
to set SIG_DFL, but sigemptyset(->blocked) and recalc_sigpending()
are not needed.

This kthread was forked by workqueue thread, all signals must be
unblocked and ignored, no pending signal is possible.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---

 kernel/kmod.c |    3 ---
 1 file changed, 3 deletions(-)

--- mm/kernel/kmod.c~1_SIGNALS	2010-02-26 22:07:38.000000000 +0100
+++ mm/kernel/kmod.c	2010-03-09 21:31:09.000000000 +0100
@@ -153,11 +153,8 @@ static int ____call_usermodehelper(void 
 	struct subprocess_info *sub_info = data;
 	int retval;
 
-	/* Unblock all signals */
 	spin_lock_irq(&current->sighand->siglock);
 	flush_signal_handlers(current, 1);
-	sigemptyset(&current->blocked);
-	recalc_sigpending();
 	spin_unlock_irq(&current->sighand->siglock);
 
 	/* We can run anywhere, unlike our parent keventd(). */


^ permalink raw reply	[flat|nested] only message in thread
only message in thread, other threads:[~2010-03-09 21:47 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-09 21:44 [PATCH -mm 1/3] call_usermodehelper: no need to unblock the signals Oleg Nesterov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.