From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: mach-shmobile: ap4evb SDHI0 platform data
Date: Wed, 10 Mar 2010 07:36:49 +0000 [thread overview]
Message-ID: <20100310073649.GD19518@linux-sh.org> (raw)
In-Reply-To: <20100310071528.5975.28821.sendpatchset@t400s>
On Wed, Mar 10, 2010 at 04:15:28PM +0900, Magnus Damm wrote:
> @@ -206,10 +207,38 @@ static struct platform_device keysc_devi
> },
> };
>
> +/* SDHI0 */
> +static struct sh_mobile_sdhi_info sdhi0_info = {
> +};
> +
Try again?
> +static struct resource sdhi0_resources[] = {
> + [0] = {
> + .name = "SDHI0",
> + .start = 0xe6850000,
> + .end = 0xe68501ff,
> + .flags = IORESOURCE_MEM,
If you aren't going to use a useful name for the resource, then the
name can just be left unset, this will ensure that the driver core
assigns the resource a name matching the device name/id pair.
So if left unset you would end up with "sh_mobile_sdhi.0" in /proc/iomem,
which could be more intuitive.
next prev parent reply other threads:[~2010-03-10 7:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-10 7:15 [PATCH] ARM: mach-shmobile: ap4evb SDHI0 platform data Magnus Damm
2010-03-10 7:36 ` Paul Mundt [this message]
2010-03-10 7:49 ` Magnus Damm
2010-03-10 7:58 ` Paul Mundt
2010-03-10 9:26 ` [PATCH] ARM: mach-shmobile: ap4evb SDHI0 platform data V2 Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100310073649.GD19518@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.