spi_s3c64xx.c - plat/spi.h: No such file or directory

spi_s3c64xx.c - plat/spi.h: No such file or directory

[Frans Pop]

When building with an SMDK6410 config with CONFIG_SPI_S3C64XX=m I get the
following compilation error:

CC [M]  drivers/spi/spi_s3c64xx.o
drivers/spi/spi_s3c64xx.c:31:22: error: plat/spi.h: No such file or directory

This is with Ben Dooks' next-samsung branch merged into 2.6.33.

Cheers,
FJP

Re: spi_s3c64xx.c - plat/spi.h: No such file or directory

[jassi brar]

On Wed, Mar 10, 2010 at 5:11 PM, Frans Pop <elendil@planet.nl> wrote:
> When building with an SMDK6410 config with CONFIG_SPI_S3C64XX=m I get the
> following compilation error:
>
> CC [M]  drivers/spi/spi_s3c64xx.o
> drivers/spi/spi_s3c64xx.c:31:22: error: plat/spi.h: No such file or directory
>
> This is with Ben Dooks' next-samsung branch merged into 2.6.33.
>
There has recently been a major shuffle of headers in plat and mach,
please test against some unmodified kernel and let me know which one
if the error still occurs. Maybe you(or I) can submit a fix upstream.

RE: spi_s3c64xx.c - plat/spi.h: No such file or directory

[Martin Krause]

Hi Frans,
hi Jassi,

linux-samsung-soc-owner@vger.kernel.org wrote on Wednesday, March 10,
2010 9:40 AM: 
> On Wed, Mar 10, 2010 at 5:11 PM, Frans Pop <elendil@planet.nl> wrote:
>> When building with an SMDK6410 config with CONFIG_SPI_S3C64XX=m I
>> get the following compilation error: 
>> 
>> CC [M]  drivers/spi/spi_s3c64xx.o
>> drivers/spi/spi_s3c64xx.c:31:22: error: plat/spi.h: No such file or
>> directory 
>> 
>> This is with Ben Dooks' next-samsung branch merged into 2.6.33.

It's funny, I tried the same yesterday, with the next-samsung-6410
kernel and run into the same error message.

On the mailing list I found the patch "[PATCH 3/6] S3C64XX SPI: Header 
for passing platform data" from 21th November 2009, which I tried.
This seems to work. Then I tried to apply the patch "[PATCH 6/6] 
SMDK6410 SPI: Added spidev support as an example" to get the SPI
driver initialized on the SMDK6410 board. But this leads to other
compile errors:

linux-2.6-samsung/arch/arm/mach-s3c6410/mach-smdk6410.c:484: undefined reference to `s3c64xx_spi_set_info'
arch/arm/mach-s3c6410/built-in.o:(.init.data+0x90): undefined reference to `s3c64xx_device_spi0'
make: *** [.tmp_vmlinux1] Error 1

And once dev-spi.c is compiled into the kernel - to resolve the 
undefined reference error - the kernel crashes during bootup 
(<4>SLUB: Unable to allocate memory on node -1 ...). After this 
I gave up.

> There has recently been a major shuffle of headers in plat and mach,
> please test against some unmodified kernel and let me know which one
> if the error still occurs. Maybe you(or I) can submit a fix upstream.

What do you mean with 'unmodified kernel'? Where can I find the
latest Kernel with S3C6410 support?

Regards,
Martin

Re: spi_s3c64xx.c - plat/spi.h: No such file or directory

[Frans Pop]

On Wednesday 10 March 2010, jassi brar wrote:
> On Wed, Mar 10, 2010 at 5:11 PM, Frans Pop <elendil@planet.nl> wrote:
> > When building with an SMDK6410 config with CONFIG_SPI_S3C64XX=m I get
> > the following compilation error:
> >
> > CC [M]  drivers/spi/spi_s3c64xx.o
> > drivers/spi/spi_s3c64xx.c:31:22: error: plat/spi.h: No such file or
> > directory
> >
> > This is with Ben Dooks' next-samsung branch merged into 2.6.33.
>
> There has recently been a major shuffle of headers in plat and mach,
> please test against some unmodified kernel and let me know which one
> if the error still occurs. Maybe you(or I) can submit a fix upstream.

The same error occurs with vanilla 2.6.33.

Cheers,
FJP

Re: spi_s3c64xx.c - plat/spi.h: No such file or directory

[jassi brar]

On Thu, Mar 11, 2010 at 1:17 AM, Frans Pop <elendil@planet.nl> wrote:
> On Wednesday 10 March 2010, jassi brar wrote:
>> On Wed, Mar 10, 2010 at 5:11 PM, Frans Pop <elendil@planet.nl> wrote:
>> > When building with an SMDK6410 config with CONFIG_SPI_S3C64XX=m I get
>> > the following compilation error:
>> >
>> > CC [M]  drivers/spi/spi_s3c64xx.o
>> > drivers/spi/spi_s3c64xx.c:31:22: error: plat/spi.h: No such file or
>> > directory
>> >
>> > This is with Ben Dooks' next-samsung branch merged into 2.6.33.
>>
>> There has recently been a major shuffle of headers in plat and mach,
>> please test against some unmodified kernel and let me know which one
>> if the error still occurs. Maybe you(or I) can submit a fix upstream.
>
> The same error occurs with vanilla 2.6.33.
yeah, i remember. that was due to driver being accepted in SPI tree but
plat headers put on hold in S3C ARCH tree.
The patches are already queued on Ben Dooks' and Grant Likely's tree.

Re: spi_s3c64xx.c - plat/spi.h: No such file or directory

[Frans Pop]

On Thursday 11 March 2010, jassi brar wrote:
> On Thu, Mar 11, 2010 at 1:17 AM, Frans Pop <elendil@planet.nl> wrote:
> > On Wednesday 10 March 2010, jassi brar wrote:
> >> On Wed, Mar 10, 2010 at 5:11 PM, Frans Pop <elendil@planet.nl> wrote:
> >> > When building with an SMDK6410 config with CONFIG_SPI_S3C64XX=m I
> >> > get the following compilation error:
> >> >
> >> > CC [M]  drivers/spi/spi_s3c64xx.o
> >> > drivers/spi/spi_s3c64xx.c:31:22: error: plat/spi.h: No such file or
> >> > directory
> >> >
> >> > This is with Ben Dooks' next-samsung branch merged into 2.6.33.
> >>
> >> There has recently been a major shuffle of headers in plat and mach,
> >> please test against some unmodified kernel and let me know which one
> >> if the error still occurs. Maybe you(or I) can submit a fix upstream.
> >
> > The same error occurs with vanilla 2.6.33.
>
> yeah, i remember. that was due to driver being accepted in SPI tree but
> plat headers put on hold in S3C ARCH tree.
> The patches are already queued on Ben Dooks' and Grant Likely's tree.

Which branch in Ben's tree would that be? As mentioned above I still see 
the error when using his current "next-samsung" branch...
I have not try building with Grant's tree.

It would be great if someone could verify that the issue really is solved.

Cheers,
FJP

Re: spi_s3c64xx.c - plat/spi.h: No such file or directory

[jassi brar]

On Thu, Mar 11, 2010 at 11:51 AM, Frans Pop <elendil@planet.nl> wrote:
> On Thursday 11 March 2010, jassi brar wrote:
>> On Thu, Mar 11, 2010 at 1:17 AM, Frans Pop <elendil@planet.nl> wrote:
>> > On Wednesday 10 March 2010, jassi brar wrote:
>> >> On Wed, Mar 10, 2010 at 5:11 PM, Frans Pop <elendil@planet.nl> wrote:
>> >> > When building with an SMDK6410 config with CONFIG_SPI_S3C64XX=m I
>> >> > get the following compilation error:
>> >> >
>> >> > CC [M]  drivers/spi/spi_s3c64xx.o
>> >> > drivers/spi/spi_s3c64xx.c:31:22: error: plat/spi.h: No such file or
>> >> > directory
>> >> >
>> >> > This is with Ben Dooks' next-samsung branch merged into 2.6.33.
>> >>
>> >> There has recently been a major shuffle of headers in plat and mach,
>> >> please test against some unmodified kernel and let me know which one
>> >> if the error still occurs. Maybe you(or I) can submit a fix upstream.
>> >
>> > The same error occurs with vanilla 2.6.33.
>>
>> yeah, i remember. that was due to driver being accepted in SPI tree but
>> plat headers put on hold in S3C ARCH tree.
>> The patches are already queued on Ben Dooks' and Grant Likely's tree.
>
> Which branch in Ben's tree would that be? As mentioned above I still see
> the error when using his current "next-samsung" branch...
> I have not try building with Grant's tree.
try for-rmk/samsung6

Re: spi_s3c64xx.c - plat/spi.h: No such file or directory

[Frans Pop]

On Thursday 11 March 2010, jassi brar wrote:
> On Thu, Mar 11, 2010 at 11:51 AM, Frans Pop <elendil@planet.nl> wrote:
> > On Thursday 11 March 2010, jassi brar wrote:
> >> On Thu, Mar 11, 2010 at 1:17 AM, Frans Pop <elendil@planet.nl> wrote:
> >> > On Wednesday 10 March 2010, jassi brar wrote:
> >> >> On Wed, Mar 10, 2010 at 5:11 PM, Frans Pop <elendil@planet.nl> 
wrote:
> >> >> > When building with an SMDK6410 config with CONFIG_SPI_S3C64XX=m
> >> >> > I get the following compilation error:
> >> >> >
> >> >> > CC [M]  drivers/spi/spi_s3c64xx.o
> >> >> > drivers/spi/spi_s3c64xx.c:31:22: error: plat/spi.h: No such file
> >> >> > or directory
> >> >> >
> >> >> > This is with Ben Dooks' next-samsung branch merged into 2.6.33.
> >> >>
> >> >> There has recently been a major shuffle of headers in plat and
> >> >> mach, please test against some unmodified kernel and let me know
> >> >> which one if the error still occurs. Maybe you(or I) can submit a
> >> >> fix upstream.
> >> >
> >> > The same error occurs with vanilla 2.6.33.
> >>
> >> yeah, i remember. that was due to driver being accepted in SPI tree
> >> but plat headers put on hold in S3C ARCH tree.
> >> The patches are already queued on Ben Dooks' and Grant Likely's tree.
> >
> > Which branch in Ben's tree would that be? As mentioned above I still
> > see the error when using his current "next-samsung" branch...
> > I have not try building with Grant's tree.
>
> try for-rmk/samsung6

That branch is identical to next-samsung...

Re: spi_s3c64xx.c - plat/spi.h: No such file or directory

[jassi brar]

On Thu, Mar 11, 2010 at 12:42 PM, Frans Pop <elendil@planet.nl> wrote:
> On Thursday 11 March 2010, jassi brar wrote:
>> On Thu, Mar 11, 2010 at 11:51 AM, Frans Pop <elendil@planet.nl> wrote:
>> > On Thursday 11 March 2010, jassi brar wrote:
>> >> On Thu, Mar 11, 2010 at 1:17 AM, Frans Pop <elendil@planet.nl> wrote:
>> >> > On Wednesday 10 March 2010, jassi brar wrote:
>> >> >> On Wed, Mar 10, 2010 at 5:11 PM, Frans Pop <elendil@planet.nl>
> wrote:
>> >> >> > When building with an SMDK6410 config with CONFIG_SPI_S3C64XX=m
>> >> >> > I get the following compilation error:
>> >> >> >
>> >> >> > CC [M]  drivers/spi/spi_s3c64xx.o
>> >> >> > drivers/spi/spi_s3c64xx.c:31:22: error: plat/spi.h: No such file
>> >> >> > or directory
>> >> >> >
>> >> >> > This is with Ben Dooks' next-samsung branch merged into 2.6.33.
>> >> >>
>> >> >> There has recently been a major shuffle of headers in plat and
>> >> >> mach, please test against some unmodified kernel and let me know
>> >> >> which one if the error still occurs. Maybe you(or I) can submit a
>> >> >> fix upstream.
>> >> >
>> >> > The same error occurs with vanilla 2.6.33.
>> >>
>> >> yeah, i remember. that was due to driver being accepted in SPI tree
>> >> but plat headers put on hold in S3C ARCH tree.
>> >> The patches are already queued on Ben Dooks' and Grant Likely's tree.
>> >
>> > Which branch in Ben's tree would that be? As mentioned above I still
>> > see the error when using his current "next-samsung" branch...
>> > I have not try building with Grant's tree.
>>
>> try for-rmk/samsung6
>
> That branch is identical to next-samsung...
>
Then you need patches from Grant Likely's tree.
The driver now includes a new header plat/s3c64xxx-spi.h instead
Check http://git.secretlab.ca/?p=linux-2.6.git;a=summary
branch 'next' or 'next-spi'

Re: spi_s3c64xx.c - plat/spi.h: No such file or directory

[Frans Pop]

On Thursday 11 March 2010, jassi brar wrote:
> Then you need patches from Grant Likely's tree.
> The driver now includes a new header plat/s3c64xxx-spi.h instead

> Check http://git.secretlab.ca/?p=linux-2.6.git;a=summary
> branch 'next' or 'next-spi'

Yep, that does work! Thanks a lot for your patience.

Cheers,
FJP

RE: spi_s3c64xx.c - plat/spi.h: No such file or directory

[Martin Krause]

Hi,

linux-samsung-soc-owner@vger.kernel.org wrote on Thursday, March 11,
2010 5:58 AM: 
> On Thursday 11 March 2010, jassi brar wrote:
>> Then you need patches from Grant Likely's tree.
>> The driver now includes a new header plat/s3c64xxx-spi.h instead
> 
>> Check http://git.secretlab.ca/?p=linux-2.6.git;a=summary
>> branch 'next' or 'next-spi'
> 
> Yep, that does work! Thanks a lot for your patience.

I tried it both, with the current 'next' and 'next-spi' branch
and get the following error:

  CC      drivers/spi/spi.o
  CC      drivers/spi/spi_s3c64xx.o
drivers/spi/spi_s3c64xx.c:31:30: error: plat/s3c64xx-spi.h: No such file or directory

The file 's3c64xx-spi.h' seems not to exist in my repo. What am I
doing wrong?

Regards,
Martin

Re: spi_s3c64xx.c - plat/spi.h: No such file or directory

[Frans Pop]

On Tuesday 23 March 2010, Martin Krause wrote:
>   CC      drivers/spi/spi.o
>   CC      drivers/spi/spi_s3c64xx.o
> drivers/spi/spi_s3c64xx.c:31:30: error: plat/s3c64xx-spi.h: No such file
> or directory
>
> The file 's3c64xx-spi.h' seems not to exist in my repo. What am I
> doing wrong?

I have it:
arch/arm/plat-samsung/include/plat/s3c64xx-spi.h

Looks like you're missing this commit:
commit 398ccccb770e6ed3e138925404f0746cbe57c5a1
Author: Jassi Brar <@@@>
Date:   Mon Jan 18 17:45:52 2010 +0900

    ARM: S3C64XX: SPI: Header for passing platform data

    We need a way to pass controller specific information to the SPI driver.
    For that purpose new headers are made.

    SPI Controller is assumed 'type-s3c64xx' and can be defined for newer SoCs.
     Hence, that part is placed under plat-samsung to be shared across newer SoCs.

    SoC specific part - spi source clocks, will be placed
    under plat-<soc>/include/plat/

Note that both samsung the and spi branches have been included in
mainline git in the mean time (for 2.6.34).

Cheers,
FJP

RE: spi_s3c64xx.c - plat/spi.h: No such file or directory

[Martin Krause]

Hi Frans,

Frans Pop wrote on Thursday, March 25, 2010 12:26 AM:
> On Tuesday 23 March 2010, Martin Krause wrote:
>>   CC      drivers/spi/spi.o
>>   CC      drivers/spi/spi_s3c64xx.o
>> drivers/spi/spi_s3c64xx.c:31:30: error: plat/s3c64xx-spi.h: No such
>> file or directory 
>> 
>> The file 's3c64xx-spi.h' seems not to exist in my repo. What am I
>> doing wrong?
> 
> I have it:
> arch/arm/plat-samsung/include/plat/s3c64xx-spi.h
> 
> Looks like you're missing this commit:
> commit 398ccccb770e6ed3e138925404f0746cbe57c5a1
> Author: Jassi Brar <@@@>
> Date:   Mon Jan 18 17:45:52 2010 +0900
> 
>     ARM: S3C64XX: SPI: Header for passing platform data
> 
>     We need a way to pass controller specific information to the SPI
>     driver. For that purpose new headers are made.
> 
>     SPI Controller is assumed 'type-s3c64xx' and can be defined for
>      newer SoCs. Hence, that part is placed under plat-samsung to be
> shared across newer SoCs. 
> 
>     SoC specific part - spi source clocks, will be placed
>     under plat-<soc>/include/plat/
> 
> Note that both samsung the and spi branches have been included in
> mainline git in the mean time (for 2.6.34).

Tanks! We tested the for-linux/samsung-fixes Branch from git.fluff.org
and that seems to work.

Regards,
Martin