From: Jean Delvare <khali@linux-fr.org>
To: Dmitri Belimov <dimon@openhardware.ru>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
hermann pitton <hermann-pitton@arcor.de>,
Andy Walls <awalls@radix.net>,
linux-media@vger.kernel.org, "Timothy D. Lenz" <tlenz@vorgon.com>
Subject: Re: [IR RC, REGRESSION] Didn't work IR RC
Date: Wed, 10 Mar 2010 10:00:19 +0100 [thread overview]
Message-ID: <20100310100019.731c7b19@hyperion.delvare> (raw)
In-Reply-To: <20100310130225.75d2bca4@glory.loctelecom.ru>
On Wed, 10 Mar 2010 13:02:25 +0900, Dmitri Belimov wrote:
> > Sorry for the late reply. Is the problem solved by now, or is my help
> > still needed?
>
> Yes. I found what happens and solve this regression. Patch already comitted.
>
> diff -r 37ff78330942 linux/drivers/media/video/saa7134/saa7134-input.c
> --- a/linux/drivers/media/video/saa7134/saa7134-input.c Sun Feb 28 16:59:57 2010 -0300
> +++ b/linux/drivers/media/video/saa7134/saa7134-input.c Thu Mar 04 08:35:15 2010 +0900
> @@ -947,6 +947,7 @@
> dev->init_data.name = "BeholdTV";
> dev->init_data.get_key = get_key_beholdm6xx;
> dev->init_data.ir_codes = &ir_codes_behold_table;
> + dev->init_data.type = IR_TYPE_NEC;
> info.addr = 0x2d;
> #endif
> break;
>
None of my patches removed this statement, and IR_TYPE_NEC itself seems
to be new in kernel 2.6.33, so I admit I don't quite understand how I
my i2c changes could be responsible for the regression.
Anyway, glad that you managed to fix it.
--
Jean Delvare
next prev parent reply other threads:[~2010-03-10 9:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-01 6:36 [IR RC, REGRESSION] Didn't work IR RC Dmitri Belimov
2010-03-01 11:28 ` Andy Walls
2010-03-01 13:37 ` Mauro Carvalho Chehab
2010-03-02 4:19 ` hermann pitton
2010-03-02 4:43 ` Dmitri Belimov
2010-03-02 7:36 ` Dmitri Belimov
2010-03-02 8:49 ` Mauro Carvalho Chehab
2010-03-09 10:57 ` Jean Delvare
2010-03-10 4:02 ` Dmitri Belimov
2010-03-10 9:00 ` Jean Delvare [this message]
2010-03-16 11:05 ` Jean Delvare
2010-03-19 13:42 ` [PATCH] FusionHDTV: Use quick reads for I2C IR device probing Jean Delvare
2010-03-29 15:34 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100310100019.731c7b19@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=awalls@radix.net \
--cc=dimon@openhardware.ru \
--cc=hermann-pitton@arcor.de \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=tlenz@vorgon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.