From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2.6.34] ARM: SAMSUNG: Fix build after "ARM: Eliminate decompressor -Dstatic= PIC hack"
Date: Wed, 10 Mar 2010 17:42:28 +0000 [thread overview]
Message-ID: <20100310174228.GA5060@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <20100310172503.GB12345@n2100.arm.linux.org.uk>
On Wed, Mar 10, 2010 at 05:25:03PM +0000, Russell King - ARM Linux wrote:
> On Wed, Mar 10, 2010 at 05:17:37PM +0000, Mark Brown wrote:
> > This is now required in mainline (2.6.34-rc1 fails to build) - given the
> > severity and lack of response I'm just going to go ahead and send it to
> > the patch tracker, hope that's OK.
> Why is error() being declared in this header file?
IIRC (it's a little while since I grovelled through) it's being used by
some of the S3C specific code for error reporting as well and the
declaration/definition from the generic code wasn't visible at the
point that code was built. Clearly not having this second, platform
specific declaration would be a better approach but due to the urgency
and closeness to release I went with a minimally invasive one line edit
in order to reduce the risk of possible side effects.
next prev parent reply other threads:[~2010-03-10 17:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-01 18:52 [PATCH 2.6.34] ARM: SAMSUNG: Fix build after "ARM: Eliminate decompressor -Dstatic= PIC hack" Mark Brown
2010-03-02 8:25 ` Uwe Kleine-König
2010-03-10 17:17 ` Mark Brown
2010-03-10 17:25 ` Russell King - ARM Linux
2010-03-10 17:42 ` Mark Brown [this message]
2010-03-10 17:46 ` Russell King - ARM Linux
2010-03-10 17:56 ` Mark Brown
2010-03-10 18:01 ` Russell King - ARM Linux
2010-03-10 18:16 ` Mark Brown
2010-03-10 18:08 ` [PATCH] ARM: Fix Samsung " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100310174228.GA5060@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.