From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] ARM: perf-events: add Realview PMU IRQs to pmu.c
Date: Wed, 10 Mar 2010 14:34:11 -0800 [thread overview]
Message-ID: <20100310223411.GU2900@atomide.com> (raw)
In-Reply-To: <20100310222731.GH4585@pc-ran3241>
* Albin Tonnerre <albin.tonnerre@gmail.com> [100310 14:22]:
> On Wed, 10 Mar 2010 13:59 -0800, Tony Lindgren wrote :
> > * Will Deacon <will.deacon@arm.com> [100310 02:46]:
> > > Add the PMU IRQs for the Realview boards to kernel/pmu.c so that
> > > they can be used by the perf-events framework.
> > >
> > > Signed-off-by: Will Deacon <will.deacon@arm.com>
> > > ---
> > > arch/arm/kernel/pmu.c | 14 ++++++++++++++
> > > 1 files changed, 14 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/arch/arm/kernel/pmu.c b/arch/arm/kernel/pmu.c
> > > index a124312..11a321e 100644
> > > --- a/arch/arm/kernel/pmu.c
> > > +++ b/arch/arm/kernel/pmu.c
> > > @@ -36,6 +36,20 @@ static const int irqs[] = {
> > > IRQ_EB11MP_PMU_CPU1,
> > > IRQ_EB11MP_PMU_CPU2,
> > > IRQ_EB11MP_PMU_CPU3,
> > > +#elif defined(CONFIG_MACH_REALVIEW_PB1176)
> > > + IRQ_DC1176_CORE_PMU,
> > > +#elif defined(CONFIG_MACH_REALVIEW_PB11MP)
> > > + IRQ_TC11MP_PMU_CPU0,
> > > + IRQ_TC11MP_PMU_CPU1,
> > > + IRQ_TC11MP_PMU_CPU2,
> > > + IRQ_TC11MP_PMU_CPU3,
> > > +#elif defined(CONFIG_MACH_REALVIEW_PBA8)
> > > + IRQ_PBA8_PMU,
> > > +#elif defined(CONFIG_MACH_REALVIEW_PBX)
> > > + IRQ_PBX_PMU_CPU0,
> > > + IRQ_PBX_PMU_CPU1,
> > > + IRQ_PBX_PMU_CPU2,
> > > + IRQ_PBX_PMU_CPU3,
> > > #elif defined(CONFIG_ARCH_OMAP3)
> > > INT_34XX_BENCH_MPU_EMUL,
> > > #elif defined(CONFIG_ARCH_IOP32X)
> >
> > Just a generic comment.. It would be nice to get rid of the
> > ifdef eliffery here for the interrupt. At least we can now
> > compile omap2 + 3 + 4 into the same binary, so stuff like
> > this caused mysterious errors easily.
>
> That's the purpose of another patch series Will has submitted as an RFC,
> see '[RFC PATCH 0/2] ARM: pmu: provide a registration mechanism for IRQs'
Oh, great! Sorry I did not notice that & thanks for doing that.
Regards,
Tony
next prev parent reply other threads:[~2010-03-10 22:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-10 10:41 [PATCH 0/6] ARM: oprofile: use perf-events framework as backend [v2] Will Deacon
2010-03-10 10:41 ` [PATCH 1/6] ARM: perf-events: add Realview PMU IRQs to pmu.c Will Deacon
2010-03-10 10:41 ` [PATCH 2/6] ARM: perf-events: use numeric ID to identify PMU Will Deacon
2010-03-10 10:41 ` [PATCH 3/6] ARM: perf-events: add support for xscale PMUs Will Deacon
2010-03-10 10:41 ` [PATCH 4/6] perf-events: export enable/disable event symbols to kernel modules Will Deacon
2010-03-10 10:41 ` [PATCH 5/6] ARM: oprofile: use perf-events framework as backend Will Deacon
2010-03-10 10:41 ` [PATCH 6/6] ARM: oprofile: remove old files and update KConfig Will Deacon
2010-03-10 10:56 ` [PATCH 4/6] perf-events: export enable/disable event symbols to kernel modules Peter Zijlstra
2010-03-10 11:47 ` Will Deacon
2010-03-10 14:30 ` Peter Zijlstra
2010-03-10 14:41 ` Will Deacon
2010-03-10 15:01 ` Robert Richter
2010-03-10 11:03 ` [PATCH 2/6] ARM: perf-events: use numeric ID to identify PMU Jamie Iles
2010-03-10 21:59 ` [PATCH 1/6] ARM: perf-events: add Realview PMU IRQs to pmu.c Tony Lindgren
2010-03-10 22:27 ` Albin Tonnerre
2010-03-10 22:34 ` Tony Lindgren [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-02-25 18:56 [PATCH 0/6] ARM: oprofile: use perf-events framework as backend Will Deacon
2010-02-25 18:56 ` [PATCH 1/6] ARM: perf-events: add Realview PMU IRQs to pmu.c Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100310223411.GU2900@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.