From: Greg KH <gregkh@suse.de>
To: David Rientjes <rientjes@google.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] numa: fix BUILD_BUG_ON for node_read_distance
Date: Wed, 10 Mar 2010 14:58:41 -0800 [thread overview]
Message-ID: <20100310225841.GA6536@suse.de> (raw)
In-Reply-To: <alpine.DEB.2.00.1003101449480.21849@chino.kir.corp.google.com>
On Wed, Mar 10, 2010 at 02:50:21PM -0800, David Rientjes wrote:
> node_read_distance() has a BUILD_BUG_ON() to prevent buffer overruns when
> the number of nodes printed will exceed the buffer length.
>
> Each node only needs four chars: three for distance (maximum distance is
> 255) and one for a seperating space or a trailing newline.
Is this causing a problem as-is today that we need to resolve for
2.6.34? Or is this 2.6.35 material?
Who chose this original number, and why is it off by 1/2?
thanks,
greg k-h
next prev parent reply other threads:[~2010-03-10 23:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-10 22:50 [patch] numa: fix BUILD_BUG_ON for node_read_distance David Rientjes
2010-03-10 22:58 ` Greg KH [this message]
2010-03-10 23:05 ` David Rientjes
2010-03-10 23:11 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100310225841.GA6536@suse.de \
--to=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.