Re: [PATCH] misc/eeprom/at24: init dynamic bin_attribute structures

[Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>]

Hi Wolfram,

On Thu, 11 Mar 2010 01:55:32 +0100, Wolfram Sang wrote:
> Commit 6992f5334995af474c2b58d010d08bc597f0f2fe introduced this requirement.
> 
> Reported-by: Albrecht Dreß <albrecht.dress-KvP5wT2u2U0@public.gmane.org>
> Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> Cc: Eric W. Biederman <ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
> Cc: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> ---
>  drivers/misc/eeprom/at24.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> Depends on:
> 
> http://thread.gmane.org/gmane.linux.drivers.i2c/5496
> 
> ([PATCH V2] at24: Fall back to byte or word reads if needed)
> 
> diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
> index 88c20da..d2deea4 100644
> --- a/drivers/misc/eeprom/at24.c
> +++ b/drivers/misc/eeprom/at24.c
> @@ -541,6 +541,7 @@ static int at24_probe(struct i2c_client *client, const struct i2c_device_id *id)
>  	at24->bin.attr.mode = chip.flags & AT24_FLAG_IRUGO ? S_IRUGO : S_IRUSR;
>  	at24->bin.read = at24_bin_read;
>  	at24->bin.size = chip.byte_len;
> +	sysfs_bin_attr_init(&at24->bin);

I think it would make more sense to move the initialization _before_
manually setting other struct members. You don't know what
sysfs_bin_attr_init does or will do in the future.

>  
>  	at24->macc.read = at24_macc_read;
>  

I presume the at25 driver needs the same fix?

-- 
Jean Delvare