All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	Luiz Capitulino <lcapitulino@redhat.com>,
	qemu-devel@nongnu.org, Gerd Hoffman <kraxel@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 1/7] Add support for generic notifier lists
Date: Thu, 11 Mar 2010 13:58:22 +0000	[thread overview]
Message-ID: <201003111358.23200.paul@codesourcery.com> (raw)
In-Reply-To: <4B98EF51.7040905@redhat.com>

> On 03/11/2010 01:57 PM, Paul Brook wrote:
> > +struct QEMUNotifier
> >
> > >  +{
> > >  +    void (*notify)(QEMUNotifier *notifier);
> > >  +};
> >
> > I suggest combining this with QEMUBH.
> 
> I didn't understand this suggestion exactly, but I think it's related
> that I didn't understand the advantage of making QEMUNotifier a struct.

My point is that we already have a mechanism for providing event notification 
callbacks, specifically QEMUBH.  Why invent a new one?

Paul

  parent reply	other threads:[~2010-03-11 14:00 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-10 16:51 [Qemu-devel] [PATCH 1/7] Add support for generic notifier lists Anthony Liguori
2010-03-10 16:51 ` [Qemu-devel] [PATCH 2/7] Rewrite mouse handlers to use QTAILQ and to have an activation function Anthony Liguori
2010-03-10 16:51 ` [Qemu-devel] [PATCH 3/7] Add kbd_mouse_has_absolute() Anthony Liguori
2010-03-10 16:51 ` [Qemu-devel] [PATCH 4/7] Add notifier for mouse mode changes Anthony Liguori
2010-03-10 16:51 ` [Qemu-devel] [PATCH 5/7] Expose whether a mouse is an absolute device via QMP and the human monitor Anthony Liguori
2010-03-11 14:15   ` [Qemu-devel] " Luiz Capitulino
2010-03-10 16:51 ` [Qemu-devel] [PATCH 6/7] input: make vnc use mouse mode notifiers Anthony Liguori
2010-03-10 22:37   ` [Qemu-devel] " Gerd Hoffmann
2010-03-10 16:51 ` [Qemu-devel] [PATCH 7/7] sdl: use mouse mode notifier Anthony Liguori
2010-03-11 12:57 ` [Qemu-devel] [PATCH 1/7] Add support for generic notifier lists Paul Brook
2010-03-11 13:25   ` [Qemu-devel] " Paolo Bonzini
2010-03-11 13:42     ` Avi Kivity
2010-03-11 14:36       ` Paolo Bonzini
2010-03-11 14:42         ` Avi Kivity
2010-03-11 15:08           ` Anthony Liguori
2010-03-11 13:58     ` Paul Brook [this message]
2010-03-11 14:39       ` Paolo Bonzini
2010-03-11 14:11     ` Anthony Liguori
2010-03-11 14:09   ` [Qemu-devel] " Anthony Liguori
2010-03-11 14:19     ` Paul Brook
2010-03-11 14:54       ` Anthony Liguori
2010-03-11 15:19         ` Avi Kivity
2010-03-15 20:31       ` Anthony Liguori
2010-03-15 23:37         ` Anthony Liguori
2010-03-11 13:36 ` Avi Kivity
2010-03-11 14:12   ` Anthony Liguori
2010-03-11 14:48     ` [Qemu-devel] [PATCH] CODING_STYLE: Reserve qemu_ prefix for library wrappers Avi Kivity
2010-03-11 14:55       ` [Qemu-devel] " Anthony Liguori
2010-03-11 23:08         ` Jamie Lokier
2010-03-12 18:47         ` Blue Swirl
2010-03-11 16:19       ` [Qemu-devel] " Markus Armbruster
2010-03-11 23:21       ` [Qemu-devel] " Juan Quintela
2010-03-12  7:58       ` [Qemu-devel] " Aurelien Jarno
2010-03-12 11:28       ` Paul Brook
2010-03-13  2:55       ` Edgar E. Iglesias
2010-03-13  8:17         ` Avi Kivity
2010-03-13 11:11           ` Edgar E. Iglesias
2010-03-22 19:39       ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201003111358.23200.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=aliguori@us.ibm.com \
    --cc=kraxel@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.