From: Andrew Morton <akpm@linux-foundation.org>
To: "Karicheri, Muralidharan" <m-karicheri2@ti.com>
Cc: "mchehab@infradead.org" <mchehab@infradead.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"julia@diku.dk" <julia@diku.dk>
Subject: Re: [patch 2/5] drivers/media/video: move dereference after NULL test
Date: Thu, 11 Mar 2010 14:59:59 -0800 [thread overview]
Message-ID: <20100311145959.287e504e.akpm@linux-foundation.org> (raw)
In-Reply-To: <A69FA2915331DC488A831521EAE36FE4016A5A3F25@dlee06.ent.ti.com>
On Thu, 11 Mar 2010 16:38:21 -0600
"Karicheri, Muralidharan" <m-karicheri2@ti.com> wrote:
> >diff -puN drivers/media/video/davinci/vpif_display.c~drivers-media-video-
> >move-dereference-after-null-test drivers/media/video/davinci/vpif_display.c
> >--- a/drivers/media/video/davinci/vpif_display.c~drivers-media-video-move-
> >dereference-after-null-test
> >+++ a/drivers/media/video/davinci/vpif_display.c
> >@@ -383,8 +383,6 @@ static int vpif_get_std_info(struct chan
> > int index;
> >
> > std_info->stdid = vid_ch->stdid;
> >- if (!std_info)
> >- return -1;
>
> Please change it as
>
> if (!std_info->stdid)
> return -1;
Could you please do this, and send the patch? It's better that way as
you're more familar with the code and maybe can even test it.
next prev parent reply other threads:[~2010-03-11 23:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-11 22:02 [patch 2/5] drivers/media/video: move dereference after NULL test akpm
2010-03-11 22:38 ` Karicheri, Muralidharan
2010-03-11 22:59 ` Andrew Morton [this message]
2010-03-12 6:28 ` Julia Lawall
2010-03-12 9:15 ` Julia Lawall
2010-03-12 22:40 ` Karicheri, Muralidharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100311145959.287e504e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=julia@diku.dk \
--cc=linux-media@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.