From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [patch 1/6] Add PPP protocol support with HDLC framing
Date: Thu, 11 Mar 2010 20:24:35 -0600 [thread overview]
Message-ID: <201003112024.35262.denkenz@gmail.com> (raw)
In-Reply-To: <20100311140030.0ce0b25f@kcaccard-MOBL3>
[-- Attachment #1: Type: text/plain, Size: 715 bytes --]
Hi Kristen,
> +struct ppp_link * g_at_ppp_new(GIOChannel *modem);
> +void g_at_ppp_open(struct ppp_link *link);
> +void g_at_ppp_set_connect_function(struct ppp_link *link,
> + GAtPPPConnectFunc callback, gpointer user_data);
> +void g_at_ppp_set_disconnect_function(struct ppp_link *link,
> + GAtPPPDisconnectFunc callback,
> + gpointer user_data);
> +void g_at_ppp_shutdown(struct ppp_link *link);
> +void g_at_ppp_ref(struct ppp_link *link);
> +void g_at_ppp_unref(struct ppp_link *link);
Almost forgot, let us not use struct ppp_link here, but instead use GAtPpp
*ppp as the parameter. Again, mostly for consistency with how glib / gatchat
does this.
Regards,
-Denis
next prev parent reply other threads:[~2010-03-12 2:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100311214022.838696145@linux.intel.com>
2010-03-11 22:00 ` [patch 1/6] Add PPP protocol support with HDLC framing kristen
2010-03-12 2:17 ` Denis Kenzior
2010-03-15 22:04 ` Kristen Carlson Accardi
2010-03-15 22:20 ` Denis Kenzior
2010-03-12 2:24 ` Denis Kenzior [this message]
2010-03-12 6:51 ` Marcel Holtmann
2010-03-11 22:00 ` [patch 2/6] Generic PPP control protocol kristen
2010-03-11 22:00 ` [patch 3/6] LCP support kristen
2010-03-11 22:00 ` [patch 4/6] CHAP with MD5 authentication kristen
2010-03-11 22:00 ` [patch 5/6] IP support for PPP kristen
2010-03-14 20:22 ` Marcel Holtmann
2010-03-16 22:53 ` Kristen Carlson Accardi
2010-03-17 4:39 ` Marcel Holtmann
2010-03-11 22:00 ` [patch 6/6] Allow gsmdial to use gatchat ppp support kristen
2010-03-14 20:02 ` Marcel Holtmann
2010-03-16 23:52 ` Kristen Carlson Accardi
[not found] <20100317000824.420232401@linux.intel.com>
2010-03-17 0:13 ` [patch 1/6] Add PPP protocol support with HDLC framing Kristen Carlson Accardi
2010-03-17 6:28 ` Marcel Holtmann
[not found] <20100319194705.214150215@linux.intel.com>
2010-03-19 19:46 ` Kristen Carlson Accardi
2010-03-20 15:33 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003112024.35262.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.