From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wengang Wang <wen.gang.wang@oracle.com>
Date: Fri, 12 Mar 2010 11:10:47 +0800
Subject: [Ocfs2-devel] [PATCH] ocfs2: prints peer node number when
 sending tcp msg failed
In-Reply-To: <4B99A21C.7020905@oracle.com>
References: <201003101313.o2ACClp1019681@acsinet15.oracle.com>
	<4B97E14E.3070902@oracle.com>
	<20100311032125.GA2497@laptop.oracle.com>
	<4B99A21C.7020905@oracle.com>
Message-ID: <20100312031047.GD2566@laptop.oracle.com>
List-Id: <ocfs2-devel.oss.oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ocfs2-devel@oss.oracle.com

On 10-03-11 18:08, Sunil Mushran wrote:
> Maybe what you are doing is better. One downside of doing it in
> o2net_send_message_vec() is that we'll get one additional message.
> And we don't want that.

If this is a consideration, I would like to print the log where
o2net_send_message() is called instead of do it inside o2net_send_message().

> 
> But no need to add a macro. Use mlog(ML_ERROR). It will let us add
> more stuff to the msg.

Ok. 
> mlog(ML_ERROR, "Error %d when sending message %u (key 0x%x) to node
> %u\n", ...);

Got it.

regards,
wengang.
> 
> Sunil
> 
> 
> Wengang Wang wrote:
> >Hi Sunil,
> >
> >On 10-03-10 10:13, Sunil Mushran wrote:
> >>Yes knowing the node number will be very useful.
> >>
> >>Wondering why not just have the mlog in o2net_send_message_vec().
> >>Fewer changes. Do you see any downside?
> >
> >No very good reason just that I think there is rule that callers print
> >the error number returned by the callee.
> >
> >If the above doesn't matter, of course your suggestion is better.
> >
> >Or you meant we print the errno returned by o2net_send_tcp_msg() with
> >node number in o2net_send_message_vec()?
> >
> >regards,
> >wengang.
> >>Wengang Wang wrote:
> >>>This patch adds prints of the number of peer node to which sending tcp message
> >>>failed. It helps debugging.
>