From: Ralf Baechle <ralf@linux-mips.org>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Wu Zhangjin <wuzhangjin@gmail.com>,
Steven Rostedt <srostedt@redhat.com>,
linux-mips@linux-mips.org,
David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH] MIPS: tracing: Optimize the implementation
Date: Fri, 12 Mar 2010 11:14:13 +0100 [thread overview]
Message-ID: <20100312101413.GA22877@linux-mips.org> (raw)
In-Reply-To: <20100312085053.GB6364@alpha.franken.de>
On Fri, Mar 12, 2010 at 09:50:53AM +0100, Thomas Bogendoerfer wrote:
> On Fri, Mar 12, 2010 at 02:07:37AM +0800, Wu Zhangjin wrote:
> > +/*
> > + * If the Instruction Pointer is in module space (0xc0000000), return ture;
> > + * otherwise, it is in kernel space (0x80000000), return false.
> > + */
> > +#define in_module(ip) (unlikely((ip) & 0x40000000))
> > +
>
> looks broken for 64bit, but maybe this is a 32bit only feature...
This gem did already exist in the old code, so no regression:
if (ip & 0x40000000) {
Ralf
next prev parent reply other threads:[~2010-03-12 10:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-11 18:07 [PATCH] MIPS: tracing: Optimize the implementation Wu Zhangjin
2010-03-12 8:50 ` Thomas Bogendoerfer
2010-03-12 10:11 ` Wu Zhangjin
2010-03-12 10:14 ` Ralf Baechle [this message]
2010-03-12 16:36 ` David Daney
[not found] ` <4B993B32.7000006@caviumnetworks.com>
2010-03-12 11:43 ` Wu Zhangjin
2010-03-12 14:57 ` Wu Zhangjin
2010-03-13 4:10 ` Wu Zhangjin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100312101413.GA22877@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=ddaney@caviumnetworks.com \
--cc=linux-mips@linux-mips.org \
--cc=srostedt@redhat.com \
--cc=tsbogend@alpha.franken.de \
--cc=wuzhangjin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.