All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Grubb <sgrubb@redhat.com>
To: linux-audit@redhat.com
Subject: Re: [PATCH] audit keys: support for multiple audit keys
Date: Fri, 12 Mar 2010 14:40:14 -0500	[thread overview]
Message-ID: <201003121440.14417.sgrubb@redhat.com> (raw)
In-Reply-To: <58f704b21003120725xf6c6078i90982a6baf7ccac0@mail.gmail.com>

On Friday 12 March 2010 10:25:31 am Juraj Hlista wrote:
> I knew that more keys can be added with the 0x01 separator. However, this
> patch supports different types of keys and plugins could recognize audit
> events using them.
> 
> For example, I'm working on reactive audit and I need to separate normal
> audit events from those generated by reactive rules and find out which
> reaction(s) should
> be triggered. -F react=reaction can be added to the audit (AUDIT_REACTKEY)
> and audit events would include reaction identifiers such as
> react="reaction"

OK, I see. What I would suggest is a mechanism with a new name. One thing I 
will point out is that the kernel prefers to work off of integers instead of 
strings. Strings are for people, numbers are for the computer. (E.g. root vs 
0.) So, I would consider calling this something else and using integers so 
that comparisons are faster.
 
-Steve

  reply	other threads:[~2010-03-12 19:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-10 17:24 [PATCH] audit keys: support for multiple audit keys Juraj Hlista
2010-03-12  7:44 ` Juraj Hlista
2010-03-12 11:31   ` Alexander Viro
2010-03-12 12:45   ` Steve Grubb
2010-03-12 15:25     ` Juraj Hlista
2010-03-12 19:40       ` Steve Grubb [this message]
2010-03-12 20:24         ` Juraj Hlista
2010-03-12 20:53           ` Steve Grubb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201003121440.14417.sgrubb@redhat.com \
    --to=sgrubb@redhat.com \
    --cc=linux-audit@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.