From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [PATCH] checkpoint: use syscall_get_error Date: Fri, 12 Mar 2010 13:35:05 -0600 Message-ID: <20100312193505.GA27295@us.ibm.com> References: <1268418393-18325-1-git-send-email-ntl@pobox.com> <1268418393-18325-3-git-send-email-ntl@pobox.com> <1268420378.3763.38.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1268420378.3763.38.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Nathan Lynch Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: containers.vger.kernel.org Quoting Nathan Lynch (ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org): > On Fri, 2010-03-12 at 12:26 -0600, Nathan Lynch wrote: > > restore_retval() uses the result of syscall_get_return_value() to > > determine whether a syscall is to return an error. This isn't > > portable and doesn't work on powerpc. Instead, use > > syscall_get_error(), which encapsulates the arch-specific logic for > > determining syscall error state. > > This one seems likely to change behavior on s390; Serge are you able to > check? > Looks like it should do the right thing, and cr_tests are still passing, so Acked-by: Serge Hallyn Tested-by: Serge Hallyn thanks, -serge