From: Florian Mickler <florian@mickler.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Marcel Holtmann <marcel@holtmann.org>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org,
Randy Dunlap <rdunlap@xenotime.net>,
Alan Jenkins <alan-jenkins@tuffmail.co.uk>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 2/2] enhance sysfs rfkill interface
Date: Fri, 12 Mar 2010 21:57:43 +0100 [thread overview]
Message-ID: <20100312215743.7671d173@schatten.dmk.lab> (raw)
In-Reply-To: <20100312182209.GB8736@core.coreip.homeip.net>
On Fri, 12 Mar 2010 10:22:09 -0800
Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> On Fri, Mar 12, 2010 at 07:03:08PM +0100, florian@mickler.org wrote:
> >
> > +static ssize_t rfkill_hard_show(struct device *dev,
> > + struct device_attribute *attr,
> > + char *buf)
> > +{
> > + struct rfkill *rfkill = to_rfkill(dev);
> > + unsigned long flags;
> > + u32 state;
> > +
> > + spin_lock_irqsave(&rfkill->lock, flags);
> > + state = rfkill->state;
> > + spin_unlock_irqrestore(&rfkill->lock, flags);
>
> Why exactly is this lock needed?
The rfkill state is updated from multiple contexts... Am I overlooking
smth obvious here?
cheers,
Flo
next prev parent reply other threads:[~2010-03-12 20:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-12 18:03 [PATCH 0/2] rfkill sysfs ABI florian
2010-03-12 18:03 ` [PATCH 1/2] Document the " florian
2010-03-12 18:03 ` [PATCH 2/2] enhance sysfs rfkill interface florian
2010-03-12 18:22 ` Dmitry Torokhov
2010-03-12 20:57 ` Florian Mickler [this message]
2010-03-12 21:20 ` Dmitry Torokhov
2010-03-12 22:39 ` Florian Mickler
2010-03-12 22:48 ` Dmitry Torokhov
2010-03-13 9:41 ` Florian Mickler
2010-03-13 9:44 ` [PATCH] rename new rfkill sysfs knobs florian
2010-03-13 9:56 ` Dmitry Torokhov
2010-03-13 12:31 ` [PATCH v2] " florian
2010-03-18 10:59 ` Florian Mickler
2010-03-18 13:42 ` John W. Linville
2010-03-13 9:55 ` [PATCH 2/2] enhance sysfs rfkill interface Dmitry Torokhov
2010-03-13 12:33 ` Florian Mickler
2010-03-12 23:48 ` Valdis.Kletnieks
2010-03-12 18:18 ` [PATCH 0/2] rfkill sysfs ABI Florian Mickler
2010-03-12 19:52 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100312215743.7671d173@schatten.dmk.lab \
--to=florian@mickler.org \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=dmitry.torokhov@gmail.com \
--cc=hmh@hmh.eng.br \
--cc=johannes@sipsolutions.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=marcel@holtmann.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.